Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what is the correlation between Sum/Gauge NumberDataPoint value and Exemplar value #319

Open
bogdandrutu opened this issue Jul 19, 2021 · 1 comment

Comments

@bogdandrutu
Copy link
Member

Right now it is possible to construct a Gauge or Sum that contains a NumberDataPoint value with as "int" see:
https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L339
and an Exemplar associated with that point that has a "double" value see https://github.com/open-telemetry/opentelemetry-proto/blob/main/opentelemetry/proto/metrics/v1/metrics.proto#L533

Is this considered a bug? What should a service do when this case happens?

@jsuereth
Copy link
Contributor

This is not a bug. We can comment on this in the data model specification.

While it is expected that a metric stream of "int" would have its measurements comprised of "int" as well (so exemplar + data point line up), it's not a requirement on the protocol.

Think this is worth opening some more language to outline what happens here, e.g. "services are free to convert double -> long" in that instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants