Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial success responses from OTLP export services #802

Closed
jmacd opened this issue Aug 19, 2022 · 4 comments · Fixed by #809 or #838
Closed

Handle partial success responses from OTLP export services #802

jmacd opened this issue Aug 19, 2022 · 4 comments · Fixed by #809 or #838
Assignees
Labels
enhancement New feature or request pinned Will not be removed by stalebot

Comments

@jmacd
Copy link

jmacd commented Aug 19, 2022

Problem Statement

Following the specification change to add partial success responses, each OTel SDK is encouraged to handle the resulting error message string in an appropriate way, considering existing norms. This requires OTLP v0.19.

Proposed Solution

For each of the Export*ServiceRequest methods used by OTLP Trace and Metrics exporters, construct an error and call the appropriate handler with the error message string and the number of spans/points(/logs) dropped. Future OTel specifications may call for optional treatment of the number of dropped items, but presently that is just additional information to include in the handled error.

@brettmc brettmc self-assigned this Aug 25, 2022
@brettmc brettmc added the enhancement New feature or request label Aug 25, 2022
@brettmc
Copy link
Collaborator

brettmc commented Aug 26, 2022

This will be partly implemented by #806.
We'll implement for http+protobuf after open-telemetry/opentelemetry-collector#5816 since we currently have no collector response to work with from that protocol.

@joaopgrassi
Copy link
Member

Hi @brettmc should we create a follow up issue to track the implementation for this for http+protobuf?

@jmacd
Copy link
Author

jmacd commented Sep 27, 2022

Let's please leave this open as long as these responses aren't handled in http/proto and http/json.

@stale
Copy link

stale bot commented Oct 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Will not be removed by stalebot
Projects
None yet
3 participants