small fixes

Author: riticksingh

contrib/OtlpGrpc/Exporter.php

@@ -63,7 +63,7 @@ class Exporter implements Trace\Exporter
     private $client;
 
     /**
-     * Exporter constructor.
+     * OTLP GRPC Exporter Constructor
      * @param string $serviceName
      */
     public function __construct(
@@ -106,8 +106,7 @@ public function export(iterable $spans): int
         foreach ($spans as $span) {
             array_push($convertedSpans, $this->spanConverter->convert($span));
         }
-        echo "$convertedSpans";
-
+        
         $request= new V1\ExportTraceServiceRequest();
         $request->setResourceSpans($convertedSpans);
 

contrib/OtlpGrpc/SpanConverter.php

@@ -8,6 +8,7 @@
 use Opentelemetry\Proto\Trace\V1\Span as CollectorSpan;
 use Opentelemetry\Proto\Trace\V1\Status\StatusCode;
 use Opentelemetry\Proto\Trace\V1\Status;
+use Opentelemetry\Proto\Common\V1\InstrumentationLibrary
 
 class SpanConverter
 {
@@ -44,7 +45,14 @@ private function sanitiseTagValue($value)
     }
 
     public function convert(Span $span)
-    {
+    {   
+        $instrumentation_library_spans=[];
+        $il=new InstrumentationLibrary();
+        $name=$il->getName();
+        $version=$il->getVersion();
+
+
+
         $spanParent = $span->getParent();
         $row = [
             'id' => $span->getContext()->getSpanId(),
@@ -56,6 +64,7 @@ public function convert(Span $span)
             'name' => $span->getSpanName(),
             'timestamp' => (int) ($span->getStartEpochTimestamp() / 1e3), // RealtimeClock in microseconds
             'duration' => (int) (($span->getEnd() - $span->getStart()) / 1e3), // Diff in microseconds
+            'trace_state' => $span->getContext();
 
         ];
 
@@ -87,10 +96,6 @@ public function convert(Span $span)
         }
         if (!array_key_exists('status', $row)) {
                 $proto_status = StatusCode::STATUS_CODE_OK;
-                //////
-                /////HIGHLIGHTED
-                ////
-                ///
                 if ($span->getStatus()->getCanonicalStatusCode() === "ERROR") {
                     $proto_status = StatusCode::STATUS_CODE_ERROR;
                 }
@@ -105,4 +110,4 @@ public function convert(Span $span)
             // $key->setKey("id")
             // $value=new AnyValue();
             // $value->setStringValue($span->getContext()->getSpanId());
-            // $key->setValue($value);
+            // $key->setValue($value);