Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The labels-filter startup parameter, flag is --label, which is inconsistent with the example and variable name. #3201

Closed
chinaran opened this issue Aug 7, 2024 · 2 comments · Fixed by #3203
Labels
area:collector Issues for deploying collector bug Something isn't working needs triage

Comments

@chinaran
Copy link
Contributor

chinaran commented Aug 7, 2024

Component(s)

collector

What happened?

Description

The labels-filter startup parameter, flag is --label, which is inconsistent with the example and variable name.

Expected Result

--labels-filter

Actual Result

--label

Kubernetes Version

v1.29.2

Operator version

v0.105.0

Collector version

v0.104.0

Environment information

No response

Log output

No response

Additional context

Reference Code: https://github.com/open-telemetry/opentelemetry-operator/blob/v0.105.0/main.go#L173

pflag.StringArrayVar(&labelsFilter,
 "label",
 []string{},
 "Labels to filter away from propagating onto deploys.
  It should be a string array containing patterns,
 which are literal strings optionally containing a * wildcard character.
  Example: --labels-filter=.*filter.out will filter out labels that looks like: label.filter.out: true")
@chinaran chinaran added bug Something isn't working needs triage labels Aug 7, 2024
@pavolloffay pavolloffay added the area:collector Issues for deploying collector label Aug 7, 2024
@pavolloffay
Copy link
Member

@chinaran would you like to fix it?

@chinaran
Copy link
Contributor Author

chinaran commented Aug 7, 2024

@chinaran would you like to fix it?

Yes, Please check #3203.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:collector Issues for deploying collector bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants