Skip to content

Sampler type for Instrumentation is required in spite of docs claiming it's optional #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swiatekm opened this issue Jul 3, 2023 · 0 comments · Fixed by #1887
Closed

Sampler type for Instrumentation is required in spite of docs claiming it's optional #1886

swiatekm opened this issue Jul 3, 2023 · 0 comments · Fixed by #1887

Comments

@swiatekm
Copy link
Contributor

swiatekm commented Jul 3, 2023

The sampler configuration is optional according to the documentation.

Since 0.80.0, trying to create a Instrumentation CR without .sampler.type set gives a spec.sampler.type is not valid error. I think this is because #1801 added unconditional validation to this field. We should either ignore empty values for that field or apply a default (AlwaysOff ?).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix .sampler.type being incorrectly required for Instrumentation swiatekm/opentelemetry-operator
1 participant
@swiatekm