Skip to content

set resource requests/limits for target-allocator #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seankhliao opened this issue Sep 16, 2022 · 6 comments · Fixed by #1739
Closed

set resource requests/limits for target-allocator #1103

seankhliao opened this issue Sep 16, 2022 · 6 comments · Fixed by #1739
Assignees
@yuriolisa
Labels
area:target-allocator Issues for target-allocator help wanted Extra attention is needed

Comments

@seankhliao
Copy link
Contributor

Our k8s clusters run with ResourceQuotas, but the deployments created by for the target allocator don't have any set, so they're blocked from creation (at the ReplicaSet level which isn't reported back upwards)
@pavolloffay pavolloffay added the area:target-allocator Issues for target-allocator label Sep 16, 2022
@seankhliao
Copy link
Contributor Author

I ran the target allocator on a larger cluster (200+ servicemonitors).
Without being able to set resource reservations, it was frequently getting OOMKilled (~10 cpu, ~18Gi memory) as it had the lowest resource requests (0).

@pavolloffay pavolloffay added the help wanted Extra attention is needed label Oct 28, 2022
@pavolloffay
Copy link
Member

@seankhliao would you like to fix it?

@seankhliao
Copy link
Contributor Author

tbh I'm not sure how I would fix it in the current structure of the CRD.
In attempting to get it to run on one of our larger clusters, I eventually had to use the rest of the PodSpec to schedule it properly (I ran it as an independent deployment without the operator).

ref: https://cloud-native.slack.com/archives/C033BJ8BASU/p1666986594165909

@yuriolisa
Copy link
Contributor

@seankhliao, can I work on it?

@seankhliao
Copy link
Contributor Author

sure

@yuriolisa yuriolisa self-assigned this Dec 7, 2022
@ilia-medvedev-codefresh
Copy link

@yuriolisa are you or anyone else working on it?

@yuriolisa yuriolisa mentioned this issue May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriolisa yuriolisa

Labels
area:target-allocator Issues for target-allocator help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set resource requests/limits for TargetAllocator yuriolisa/opentelemetry-operator
4 participants
@pavolloffay @seankhliao @yuriolisa @ilia-medvedev-codefresh