chore(sdk-node): migrate to the new sdk-trace package by trentm · Pull Request #6828 · open-telemetry/opentelemetry-js

trentm · 2026-06-18T19:58:19Z

This deprecates the existing 'node' and 'tracing' re-exports of the sdk-trace-node and sdk-trace-base packages, which themselves will soon be deprecated.

We decided to not add a replacement re-export of the sdk-trace package.
The recommendation is now that users should export directly from the other packages.
See #6824 and #5461 for discussion.

Refs: #6775

This is the first of some changes to migrate all usages of sdk-trace-base, sdk-trace-node, and sdk-trace-web in the core and contrib repos over to sdk-trace. The usage in sdk-node was, I think, the big one. So it was helpful to do it in a separate PR.

There should be no functional change other than the added trace re-export (see src/index.ts).

This adds a new 'trace' export, which re-exports the sdk-trace package. This is meant as a replacement for the existing 'node' and 'tracing' re-exports of the sdk-trace-node and sdk-trace-base packages, which will soon be deprecated.

codecov · 2026-06-18T20:00:51Z

Codecov Report

❌ Patch coverage is 98.71795% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.52%. Comparing base (e6e5e19) to head (16f091a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/opentelemetry-sdk-node/src/create-from-config.ts	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6828      +/-   ##
==========================================
+ Coverage   95.51%   95.52%   +0.01%     
==========================================
  Files         382      384       +2     
  Lines       12941    12974      +33     
  Branches     2967     2976       +9     
==========================================
+ Hits        12360    12394      +34     
+ Misses        581      580       -1

Files with missing lines	Coverage Δ
...ages/opentelemetry-sdk-node/src/create-from-env.ts	`100.00% <100.00%> (ø)`
...imental/packages/opentelemetry-sdk-node/src/sdk.ts	`96.93% <100.00%> (+1.00%)`	⬆️
...ental/packages/opentelemetry-sdk-node/src/start.ts	`97.00% <100.00%> (-0.06%)`	⬇️
...ental/packages/opentelemetry-sdk-node/src/utils.ts	`96.41% <100.00%> (-0.09%)`	⬇️
...s/opentelemetry-sdk-node/src/create-from-config.ts	`93.33% <93.33%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

trentm · 2026-06-18T20:04:19Z

+} from '@opentelemetry/configuration';
+import type { SpanLimits } from '@opentelemetry/sdk-trace';
+
+export function createSpanLimitsFromConfig(


Note: This continues the create<SDK Thing>FromConfig() pattern started in #6785

I've also started moving "FromConfig"-specific things to this file, from the overly large "utils.ts".
I think it'll be helpful for maint and testing to separate the "FromEnv" handling and the "FromConfig" handling. Over a number of PRs I'll move/re-implement things in utils.ts over to "create-from-config.ts" and "create-from-env.ts".

trentm · 2026-06-18T20:05:20Z

+
+const DEFAULT_RATIO = 1;
+
+export function createSamplerFromEnv(): Sampler | undefined {


Note: Adapted from buildSamplerFromEnv in sdk-trace-base:

opentelemetry-js/packages/opentelemetry-sdk-trace-base/src/config.ts

Line 64 in 041b5f4

export function buildSamplerFromEnv(): Sampler {

trentm · 2026-06-18T20:06:11Z

+  return ratio;
+}
+
+export function createSpanLimitsFromEnv(): SpanLimits | undefined {


Note: Adapted from reconfigureLimits in sdk-trace-base:

opentelemetry-js/packages/opentelemetry-sdk-trace-base/src/utility.ts

Line 17 in 041b5f4

export function reconfigureLimits(userConfig: TracerConfig): TracerConfig {

trentm · 2026-06-18T20:07:28Z

+export * as node from '@opentelemetry/sdk-trace-node';
+/**
+ * @deprecated Use `trace` re-export from `@opentelemetry/sdk-trace` instead.
+ */
 export * as tracing from '@opentelemetry/sdk-trace-base';


Note: These existing re-exports are the only reason sdk-node cannot yet drop its dep on sdk-trace-node and sdk-trace-base. We'll drop these with SDK 3.0.

I see you opened #6824. If you're feeling adventurous, we could also try to remove it and see if anybody is unhappy with that. I'd be willing to bet that almost nobody is using these re-exports.

We don't need to do it in this PR though, let's keep this low-friction for now.

trentm · 2026-06-18T20:08:53Z

-      this._tracerProviderConfig = {
-        tracerConfig: tracerProviderConfig,
-        spanProcessors,
-      };


Note: All of this handling of input config options for span processors is moved (and cleaned up) to and if-block in .start() below.

trentm · 2026-06-18T20:10:02Z

-      if (configuration.sampler) {
-        tracerProviderConfig.sampler = configuration.sampler;
-      }
-      if (configuration.spanLimits) {
-        tracerProviderConfig.spanLimits = configuration.spanLimits;
-      }
-      if (configuration.idGenerator) {
-        tracerProviderConfig.idGenerator = configuration.idGenerator;
-      }


Note: This tracerProviderConfig was never used.

pichlermarc

Overall looks good, thanks for working on this 🙌
(just one comment about the re-exports; non-blocking)

…edback from Marc)

feat(sdk-node): migrate to the new sdk-trace package

930abcf

This adds a new 'trace' export, which re-exports the sdk-trace package. This is meant as a replacement for the existing 'node' and 'tracing' re-exports of the sdk-trace-node and sdk-trace-base packages, which will soon be deprecated.

trentm self-assigned this Jun 18, 2026

trentm requested a review from a team as a code owner June 18, 2026 19:58

trentm added this to Declarative Configuration: JavaScript Jun 18, 2026

trentm moved this to In Progress in Declarative Configuration: JavaScript Jun 18, 2026

trentm mentioned this pull request Jun 18, 2026

chore(configuration)!: change parseConfigFile() to *not* add default values, nor merge *_list fields #6765

Merged

trentm commented Jun 18, 2026

View reviewed changes

trentm added a commit to anuraaga/opentelemetry-js that referenced this pull request Jun 19, 2026

add a temp fix, waiting for open-telemetry#6828 to merge first

0b26d3e

trentm mentioned this pull request Jun 19, 2026

feat(sdk-trace)!: implement span processor metrics; change SimpleSpanProcessor constructor call signature #6504

Merged

8 tasks

Merge branch 'main' into trentm-use-sdk-trace-take1

0e58a94

pichlermarc approved these changes Jun 19, 2026

View reviewed changes

Comment thread experimental/packages/opentelemetry-sdk-node/src/index.ts Outdated

david-luna approved these changes Jun 19, 2026

View reviewed changes

trentm added 2 commits June 19, 2026 10:57

*don't* add the 'trace' re-export, let's move away from those (per fe…

22daaab

…edback from Marc)

fix lint:markdown

16f091a

trentm enabled auto-merge June 19, 2026 18:09

trentm disabled auto-merge June 19, 2026 18:09

trentm changed the title ~~feat(sdk-node): migrate to the new sdk-trace package~~ chore(sdk-node): migrate to the new sdk-trace package Jun 19, 2026

trentm enabled auto-merge June 19, 2026 18:09

trentm added this pull request to the merge queue Jun 19, 2026

Merged via the queue into open-telemetry:main with commit 9d7628f Jun 19, 2026
29 checks passed

trentm deleted the trentm-use-sdk-trace-take1 branch June 19, 2026 18:17

github-project-automation Bot moved this from In Progress to Done in Declarative Configuration: JavaScript Jun 19, 2026

trentm mentioned this pull request Jun 25, 2026

chore(*): migrate use of sdk-trace-base and sdk-trace-node to sdk-trace #6851

Merged

otelbot-js Bot mentioned this pull request Jul 2, 2026

chore: prepare next release #6869

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(sdk-node): migrate to the new sdk-trace package#6828

chore(sdk-node): migrate to the new sdk-trace package#6828
trentm merged 4 commits into
open-telemetry:mainfrom
trentm:trentm-use-sdk-trace-take1

trentm commented Jun 18, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

trentm Jun 18, 2026

Uh oh!

trentm Jun 18, 2026

Uh oh!

trentm Jun 18, 2026

Uh oh!

trentm Jun 18, 2026

Uh oh!

pichlermarc Jun 19, 2026

Uh oh!

trentm Jun 18, 2026

Uh oh!

trentm Jun 18, 2026

Uh oh!

pichlermarc left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		const DEFAULT_RATIO = 1;

		export function createSamplerFromEnv(): Sampler \| undefined {

Uh oh!

Conversation

trentm commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

pichlermarc Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

trentm Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

pichlermarc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

trentm commented Jun 18, 2026 •

edited

Loading

codecov Bot commented Jun 18, 2026 •

edited

Loading