From 0e57e8ecc7ca76a889119b050052d1b6a5fb0ca4 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 1 Feb 2026 18:16:53 -0500 Subject: [PATCH 1/2] refactor(sdk-logs): remove unnecessary closure in _maybeStartTimer() --- experimental/CHANGELOG.md | 1 + .../packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 8603131571d..98d29e9a462 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -27,6 +27,7 @@ feat(configuration): parse config for rc 3 [#6304](https://github.com/open-telem ### :house: Internal * perf(otlp-transformer): optimize toAnyValue performance [#6287](https://github.com/open-telemetry/opentelemetry-js/pull/6287) @AbhiPrasad +* refactor(sdk-logs): remove unnecessary closure in \_maybeStartTimer() [#xxxx](https://github.com/open-telemetry/opentelemetry-js/pull/xxxx) @cjihrig ## 0.211.0 diff --git a/experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts b/experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts index 9f5df1bbe06..4481fef251b 100644 --- a/experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts +++ b/experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts @@ -150,7 +150,7 @@ export abstract class BatchLogRecordProcessorBase return flush(); } if (this._timer !== undefined) return; - this._timer = setTimeout(() => flush(), this._scheduledDelayMillis); + this._timer = setTimeout(flush, this._scheduledDelayMillis); // depending on runtime, this may be a 'number' or NodeJS.Timeout if (typeof this._timer !== 'number') { this._timer.unref(); From 687076446c2a5af5b27f0267764bcc7ade895e78 Mon Sep 17 00:00:00 2001 From: Colin Ihrig Date: Sun, 1 Feb 2026 18:19:51 -0500 Subject: [PATCH 2/2] Apply suggestion from @cjihrig --- experimental/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 98d29e9a462..5e7bbea616b 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -27,7 +27,7 @@ feat(configuration): parse config for rc 3 [#6304](https://github.com/open-telem ### :house: Internal * perf(otlp-transformer): optimize toAnyValue performance [#6287](https://github.com/open-telemetry/opentelemetry-js/pull/6287) @AbhiPrasad -* refactor(sdk-logs): remove unnecessary closure in \_maybeStartTimer() [#xxxx](https://github.com/open-telemetry/opentelemetry-js/pull/xxxx) @cjihrig +* refactor(sdk-logs): remove unnecessary closure in \_maybeStartTimer() [#6361](https://github.com/open-telemetry/opentelemetry-js/pull/6361) @cjihrig ## 0.211.0