Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metric handle to bound instrument #634

Closed
dyladan opened this issue Dec 17, 2019 · 4 comments
Closed

Rename metric handle to bound instrument #634

dyladan opened this issue Dec 17, 2019 · 4 comments
Assignees
@cthulhu-bot @dyladan
Labels
good first issue Good for newcomers
Milestone
Alpha v0.3.2

Comments

@dyladan
Copy link
Member

dyladan commented Dec 17, 2019

Spec issue: open-telemetry/opentelemetry-specification#392

OTEP was approved and the spec change is very minimal. I expect that this will go through basically unchanged.
@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Dec 17, 2019
@dyladan dyladan added this to the Alpha v0.4 milestone Dec 17, 2019
@dyladan
Copy link
Member Author

dyladan commented Dec 18, 2019

Looks like the spec issue just merged. I'll leave this for a little bit and if no-one picks it up soon i'll handle it.

@cthulhu-bot
Copy link
Contributor

looking to get involved would you mind if I did the rename Dan?

@dyladan
Copy link
Member Author

dyladan commented Dec 18, 2019

@cthulhu-bot of course!

I'm going to assign us both to this so that I can keep it on my radar as well.

cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 20, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
6aaa73f
@cthulhu-bot cthulhu-bot mentioned this issue Dec 20, 2019
Merged
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 20, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
2836cee
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 20, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
9e8d389
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 20, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
343294f
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 21, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
4679267
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 21, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
8ba8768
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 22, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
df15b31
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 23, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
98e9891
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.4, Alpha v0.3.2 Dec 23, 2019
cthulhu-bot added a commit to cthulhu-bot/opentelemetry-js that referenced this issue Dec 26, 2019
@cthulhu-bot
chore: rename Metric Handle to Bound Instrument (open-telemetry#634)
bbde5ce 
* chore: fix renames in metrics test

* chore: fix formatting

* chore: rename BaseInstrument to BaseBoundInstrument
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jan 2, 2020
mayurkale22 added a commit that referenced this issue Jan 3, 2020
@cthulhu-bot @mayurkale22
chore: rename Metric Handle to Bound Instrument (#634) (#638)
6f0084f 
* chore: fix renames in metrics test

* chore: fix formatting

* chore: rename BaseInstrument to BaseBoundInstrument

Co-authored-by: Mayur Kale <[email protected]>
@mayurkale22
Copy link
Member

Closed via #638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-bot cthulhu-bot

@dyladan dyladan

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Alpha v0.3.2
Development

No branches or pull requests
3 participants
@cthulhu-bot @dyladan @mayurkale22