diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md index 1abdb269513..9c2f2b1d917 100644 --- a/experimental/CHANGELOG.md +++ b/experimental/CHANGELOG.md @@ -17,6 +17,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2 * feat(configuration): set tracer provider exporter type from env variables [#6106](https://github.com/open-telemetry/opentelemetry-js/pull/6106) @maryliag * feat(configuration): set meter provider exporter type from env variable [#6105](https://github.com/open-telemetry/opentelemetry-js/pull/6105) @maryliag * refactor(configuration): throw warning and not error for invalid files [#6124](https://github.com/open-telemetry/opentelemetry-js/pull/6124) @maryliag +* refactor(configuration): dont have a default value for node resource detectors [#x](https://github.com/open-telemetry/opentelemetry-js/pull/x) @maryliag ### :bug: Bug Fixes diff --git a/experimental/packages/configuration/src/models/configModel.ts b/experimental/packages/configuration/src/models/configModel.ts index 63450cf8d1b..dd323b9ba38 100644 --- a/experimental/packages/configuration/src/models/configModel.ts +++ b/experimental/packages/configuration/src/models/configModel.ts @@ -86,7 +86,6 @@ export function initializeDefaultConfiguration(): ConfigurationModel { const config: ConfigurationModel = { disabled: false, log_level: DiagLogLevel.INFO, - node_resource_detectors: ['all'], resource: {}, attribute_limits: { attribute_count_limit: 128, diff --git a/experimental/packages/configuration/test/ConfigFactory.test.ts b/experimental/packages/configuration/test/ConfigFactory.test.ts index 1ddba57affc..dbd1e73fcea 100644 --- a/experimental/packages/configuration/test/ConfigFactory.test.ts +++ b/experimental/packages/configuration/test/ConfigFactory.test.ts @@ -48,7 +48,6 @@ import { const defaultConfig: ConfigurationModel = { disabled: false, log_level: DiagLogLevel.INFO, - node_resource_detectors: ['all'], resource: {}, attribute_limits: { attribute_count_limit: 128, @@ -140,7 +139,6 @@ const defaultConfig: ConfigurationModel = { const configFromFile: ConfigurationModel = { disabled: false, log_level: DiagLogLevel.INFO, - node_resource_detectors: ['all'], resource: { schema_url: 'https://opentelemetry.io/schemas/1.16.0', attributes_list: 'service.namespace=my-namespace,service.version=1.0.0', @@ -631,7 +629,6 @@ const configFromFile: ConfigurationModel = { const defaultConfigFromFileWithEnvVariables: ConfigurationModel = { disabled: false, log_level: DiagLogLevel.INFO, - node_resource_detectors: ['all'], resource: { attributes: [ {