From 5ceeb45e3bd8548c4b63e3ceef6621294a07dd6c Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Sun, 2 Jun 2024 17:18:20 -0400 Subject: [PATCH 1/3] refactor(examples/http): use new exported string constants for semconv --- examples/http/tracer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/http/tracer.js b/examples/http/tracer.js index 82dbca2f70a..07de8a86379 100644 --- a/examples/http/tracer.js +++ b/examples/http/tracer.js @@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api'); const { registerInstrumentations } = require('@opentelemetry/instrumentation'); const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node'); const { Resource } = require('@opentelemetry/resources'); -const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions'); +const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions'); const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base'); const { JaegerExporter } = require('@opentelemetry/exporter-jaeger'); const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin'); From bf7bfcb21b23c4aa6367399319226043293ec92b Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Sun, 2 Jun 2024 18:31:24 -0400 Subject: [PATCH 2/3] added changelog entry --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 869e21f71a0..289716b7415 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/ ### :books: (Refine Doc) +* refactor(examples): use new exported string constants for semconv in examples/http [#4750](https://github.com/open-telemetry/opentelemetry-js/pull/4750) @Zen-cronic + ### :house: (Internal) ## 1.24.1 From f0764cc8e7d896c75ce2e43ed488f72ac9f19532 Mon Sep 17 00:00:00 2001 From: Zen-cronic <83657429+Zen-cronic@users.noreply.github.com> Date: Mon, 3 Jun 2024 14:03:55 -0400 Subject: [PATCH 3/3] refactor(examples/http): actually use new exported string constants for semconv --- examples/http/tracer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/http/tracer.js b/examples/http/tracer.js index 07de8a86379..b2351221bde 100644 --- a/examples/http/tracer.js +++ b/examples/http/tracer.js @@ -15,7 +15,7 @@ const EXPORTER = process.env.EXPORTER || ''; module.exports = (serviceName) => { const provider = new NodeTracerProvider({ resource: new Resource({ - [SemanticResourceAttributes.SERVICE_NAME]: serviceName, + [SEMRESATTRS_SERVICE_NAME]: serviceName, }), });