From 72aac6598cf5485d6f5d6e5a39498b57f1723c77 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:07:11 -0400 Subject: [PATCH 1/8] ci: run browser tests without circle --- .github/workflows/unit-test.yml | 284 ++++++++++++++++---------------- karma.base.js | 8 +- 2 files changed, 150 insertions(+), 142 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 8fc5e17ba2..36a42f2363 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -6,118 +6,120 @@ on: pull_request: jobs: - node-tests: - strategy: - fail-fast: false - matrix: - node_version: - - "14" - - "16" - - "18" + # node-tests: + # strategy: + # fail-fast: false + # matrix: + # node_version: + # - "14" + # - "16" + # - "18" + # runs-on: ubuntu-latest + # env: + # NPM_CONFIG_UNSAFE_PERM: true + # steps: + # - name: Checkout + # uses: actions/checkout@v3 + + # - uses: actions/setup-node@v3 + # with: + # node-version: ${{ matrix.node_version }} + + # - run: npm install -g npm@latest + + # - name: restore lerna + # id: cache + # uses: actions/cache@v3 + # with: + # path: | + # node_modules + # package-lock.json + # packages/*/node_modules + # packages/*/package-lock.json + # experimental/packages/*/node_modules + # experimental/packages/*/package-lock.json + # key: node-tests-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + + # - name: Bootstrap + # run: | + # npm install --ignore-scripts + # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests + + # - name: Build 🔧 + # run: | + # npm run compile + + # - name: Unit tests + # run: npm run test + # - name: Report Coverage + # run: npm run codecov + # if: ${{ matrix.node_version == '14' }} + # node-windows-tests: + # strategy: + # fail-fast: false + # runs-on: windows-latest + # env: + # NPM_CONFIG_UNSAFE_PERM: true + # steps: + # - name: Checkout + # uses: actions/checkout@v3 + + # - uses: actions/setup-node@v3 + # with: + # node-version: '16' + + # - run: npm install -g npm@latest + + # - name: restore lerna + # id: cache + # uses: actions/cache@v3 + # with: + # path: | + # node_modules + # package-lock.json + # packages/*/node_modules + # packages/*/package-lock.json + # experimental/packages/*/node_modules + # experimental/packages/*/package-lock.json + # key: node-windows-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }} + + # - name: Bootstrap + # run: | + # npm install --ignore-scripts + # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests + + # - name: Build 🔧 + # run: | + # npm run compile + + # - name: Unit tests + # run: npm run test + browser-tests: runs-on: ubuntu-latest - env: - NPM_CONFIG_UNSAFE_PERM: true - steps: - - name: Checkout - uses: actions/checkout@v3 - - - uses: actions/setup-node@v3 - with: - node-version: ${{ matrix.node_version }} - - - run: npm install -g npm@latest - - - name: restore lerna - id: cache - uses: actions/cache@v3 - with: - path: | - node_modules - package-lock.json - packages/*/node_modules - packages/*/package-lock.json - experimental/packages/*/node_modules - experimental/packages/*/package-lock.json - key: node-tests-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - - - name: Bootstrap - run: | - npm install --ignore-scripts - npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests - - - name: Build 🔧 - run: | - npm run compile - - name: Unit tests - run: npm run test - - name: Report Coverage - run: npm run codecov - if: ${{ matrix.node_version == '14' }} - node-windows-tests: - strategy: - fail-fast: false - runs-on: windows-latest env: NPM_CONFIG_UNSAFE_PERM: true steps: - name: Checkout uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: '16' - - run: npm install -g npm@latest - - - name: restore lerna - id: cache - uses: actions/cache@v3 + - uses: actions/setup-node@v3 with: - path: | - node_modules - package-lock.json - packages/*/node_modules - packages/*/package-lock.json - experimental/packages/*/node_modules - experimental/packages/*/package-lock.json - key: node-windows-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }} - - - name: Bootstrap - run: | - npm install --ignore-scripts - npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests - - - name: Build 🔧 - run: | - npm run compile - - - name: Unit tests - run: npm run test - browser-tests: - runs-on: ubuntu-latest - container: - image: circleci/node:16-browsers - env: - NPM_CONFIG_UNSAFE_PERM: true - steps: - - name: Permission Setup - run: sudo chmod -R 777 /github /__w - - name: Checkout - uses: actions/checkout@v3.0.2 + node-version: ${{ matrix.node_version }} - - name: restore lerna - id: cache - uses: actions/cache@v3 - with: - path: | - node_modules - package-lock.json - packages/*/node_modules - packages/*/package-lock.json - experimental/packages/*/node_modules - experimental/packages/*/package-lock.json - key: browser-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + # - name: restore lerna + # id: cache + # uses: actions/cache@v3 + # with: + # path: | + # node_modules + # package-lock.json + # packages/*/node_modules + # packages/*/package-lock.json + # experimental/packages/*/node_modules + # experimental/packages/*/package-lock.json + # key: browser-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - name: Bootstrap run: | @@ -134,43 +136,43 @@ jobs: run: npm run test:browser - name: Report Coverage run: npm run codecov:browser - webworker-tests: - runs-on: ubuntu-latest - container: - image: circleci/node:16-browsers - env: - NPM_CONFIG_UNSAFE_PERM: true - steps: - - name: Permission Setup - run: sudo chmod -R 777 /github /__w - - name: Checkout - uses: actions/checkout@v3.0.2 - - - name: restore lerna - id: cache - uses: actions/cache@v3 - with: - path: | - node_modules - package-lock.json - packages/*/node_modules - packages/*/package-lock.json - experimental/packages/*/node_modules - experimental/packages/*/package-lock.json - key: webworker-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - - - name: Bootstrap - run: | - npm install --ignore-scripts - npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' - - - name: Build 🔧 - run: | - npm run compile - # run additional compilation variants - npx lerna run compile - - - name: Unit tests - run: npm run test:webworker - - name: Report Coverage - run: npm run codecov:webworker + # webworker-tests: + # runs-on: ubuntu-latest + # container: + # image: circleci/node:16-browsers + # env: + # NPM_CONFIG_UNSAFE_PERM: true + # steps: + # - name: Permission Setup + # run: sudo chmod -R 777 /github /__w + # - name: Checkout + # uses: actions/checkout@v3.0.2 + + # - name: restore lerna + # id: cache + # uses: actions/cache@v3 + # with: + # path: | + # node_modules + # package-lock.json + # packages/*/node_modules + # packages/*/package-lock.json + # experimental/packages/*/node_modules + # experimental/packages/*/package-lock.json + # key: webworker-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + + # - name: Bootstrap + # run: | + # npm install --ignore-scripts + # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' + + # - name: Build 🔧 + # run: | + # npm run compile + # # run additional compilation variants + # npx lerna run compile + + # - name: Unit tests + # run: npm run test:webworker + # - name: Report Coverage + # run: npm run codecov:webworker diff --git a/karma.base.js b/karma.base.js index 7df76d7b13..4a1e51053f 100644 --- a/karma.base.js +++ b/karma.base.js @@ -17,7 +17,13 @@ module.exports = { listenAddress: 'localhost', hostname: 'localhost', - browsers: ['ChromeHeadless'], + browsers: ['Chrome', 'ChromeHeadless', 'ChromeHeadlessCI'], + customLaunchers: { + ChromeHeadlessCI: { + base: 'ChromeHeadless', + flags: ['--no-sandbox'] + } + }, frameworks: ['mocha'], coverageIstanbulReporter: { reports: ['html', 'json'], From 1d410ba9ba2e8b03847d72ca252466edd94980d9 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:24:27 -0400 Subject: [PATCH 2/8] Reduce scope --- .github/workflows/unit-test.yml | 12 ++++++------ karma.base.js | 8 +------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 36a42f2363..75142cc94e 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -124,18 +124,18 @@ jobs: - name: Bootstrap run: | npm install --ignore-scripts - npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests + npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests --scope @opentelemetry/core --include-dependencies - name: Build 🔧 run: | - npm run compile + # npm run compile # run additional compilation variants - npx lerna run compile + npx lerna run compile --scope @opentelemetry/core --include-dependencies - name: Unit tests - run: npm run test:browser - - name: Report Coverage - run: npm run codecov:browser + run: npm run test:browser --scope @opentelemetry/core --include-dependencies + # - name: Report Coverage + # run: npm run codecov:browser # webworker-tests: # runs-on: ubuntu-latest # container: diff --git a/karma.base.js b/karma.base.js index 4a1e51053f..7df76d7b13 100644 --- a/karma.base.js +++ b/karma.base.js @@ -17,13 +17,7 @@ module.exports = { listenAddress: 'localhost', hostname: 'localhost', - browsers: ['Chrome', 'ChromeHeadless', 'ChromeHeadlessCI'], - customLaunchers: { - ChromeHeadlessCI: { - base: 'ChromeHeadless', - flags: ['--no-sandbox'] - } - }, + browsers: ['ChromeHeadless'], frameworks: ['mocha'], coverageIstanbulReporter: { reports: ['html', 'json'], From b3dd1f580f8d28d316b4705c6239393363c461b8 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:27:58 -0400 Subject: [PATCH 3/8] Bring back other tests --- .github/workflows/unit-test.yml | 290 ++++++++++++++++---------------- 1 file changed, 145 insertions(+), 145 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 75142cc94e..c3cdfda722 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -6,94 +6,94 @@ on: pull_request: jobs: - # node-tests: - # strategy: - # fail-fast: false - # matrix: - # node_version: - # - "14" - # - "16" - # - "18" - # runs-on: ubuntu-latest - # env: - # NPM_CONFIG_UNSAFE_PERM: true - # steps: - # - name: Checkout - # uses: actions/checkout@v3 - - # - uses: actions/setup-node@v3 - # with: - # node-version: ${{ matrix.node_version }} - - # - run: npm install -g npm@latest - - # - name: restore lerna - # id: cache - # uses: actions/cache@v3 - # with: - # path: | - # node_modules - # package-lock.json - # packages/*/node_modules - # packages/*/package-lock.json - # experimental/packages/*/node_modules - # experimental/packages/*/package-lock.json - # key: node-tests-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - - # - name: Bootstrap - # run: | - # npm install --ignore-scripts - # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests - - # - name: Build 🔧 - # run: | - # npm run compile - - # - name: Unit tests - # run: npm run test - # - name: Report Coverage - # run: npm run codecov - # if: ${{ matrix.node_version == '14' }} - # node-windows-tests: - # strategy: - # fail-fast: false - # runs-on: windows-latest - # env: - # NPM_CONFIG_UNSAFE_PERM: true - # steps: - # - name: Checkout - # uses: actions/checkout@v3 - - # - uses: actions/setup-node@v3 - # with: - # node-version: '16' - - # - run: npm install -g npm@latest - - # - name: restore lerna - # id: cache - # uses: actions/cache@v3 - # with: - # path: | - # node_modules - # package-lock.json - # packages/*/node_modules - # packages/*/package-lock.json - # experimental/packages/*/node_modules - # experimental/packages/*/package-lock.json - # key: node-windows-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }} - - # - name: Bootstrap - # run: | - # npm install --ignore-scripts - # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests - - # - name: Build 🔧 - # run: | - # npm run compile - - # - name: Unit tests - # run: npm run test + node-tests: + strategy: + fail-fast: false + matrix: + node_version: + - "14" + - "16" + - "18" + runs-on: ubuntu-latest + env: + NPM_CONFIG_UNSAFE_PERM: true + steps: + - name: Checkout + uses: actions/checkout@v3 + + - uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node_version }} + + - run: npm install -g npm@latest + + - name: restore lerna + id: cache + uses: actions/cache@v3 + with: + path: | + node_modules + package-lock.json + packages/*/node_modules + packages/*/package-lock.json + experimental/packages/*/node_modules + experimental/packages/*/package-lock.json + key: node-tests-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + + - name: Bootstrap + run: | + npm install --ignore-scripts + npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests + + - name: Build 🔧 + run: | + npm run compile + + - name: Unit tests + run: npm run test + - name: Report Coverage + run: npm run codecov + if: ${{ matrix.node_version == '14' }} + node-windows-tests: + strategy: + fail-fast: false + runs-on: windows-latest + env: + NPM_CONFIG_UNSAFE_PERM: true + steps: + - name: Checkout + uses: actions/checkout@v3 + + - uses: actions/setup-node@v3 + with: + node-version: '16' + + - run: npm install -g npm@latest + + - name: restore lerna + id: cache + uses: actions/cache@v3 + with: + path: | + node_modules + package-lock.json + packages/*/node_modules + packages/*/package-lock.json + experimental/packages/*/node_modules + experimental/packages/*/package-lock.json + key: node-windows-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }} + + - name: Bootstrap + run: | + npm install --ignore-scripts + npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests + + - name: Build 🔧 + run: | + npm run compile + + - name: Unit tests + run: npm run test browser-tests: runs-on: ubuntu-latest @@ -108,71 +108,71 @@ jobs: with: node-version: ${{ matrix.node_version }} - # - name: restore lerna - # id: cache - # uses: actions/cache@v3 - # with: - # path: | - # node_modules - # package-lock.json - # packages/*/node_modules - # packages/*/package-lock.json - # experimental/packages/*/node_modules - # experimental/packages/*/package-lock.json - # key: browser-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + - name: restore lerna + id: cache + uses: actions/cache@v3 + with: + path: | + node_modules + package-lock.json + packages/*/node_modules + packages/*/package-lock.json + experimental/packages/*/node_modules + experimental/packages/*/package-lock.json + key: browser-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - name: Bootstrap run: | npm install --ignore-scripts - npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests --scope @opentelemetry/core --include-dependencies + npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests - name: Build 🔧 run: | # npm run compile # run additional compilation variants - npx lerna run compile --scope @opentelemetry/core --include-dependencies + npx lerna run compile + + - name: Unit tests + run: npm run test:browser + - name: Report Coverage + run: npm run codecov:browser + webworker-tests: + runs-on: ubuntu-latest + container: + image: circleci/node:16-browsers + env: + NPM_CONFIG_UNSAFE_PERM: true + steps: + - name: Permission Setup + run: sudo chmod -R 777 /github /__w + - name: Checkout + uses: actions/checkout@v3.0.2 + + - name: restore lerna + id: cache + uses: actions/cache@v3 + with: + path: | + node_modules + package-lock.json + packages/*/node_modules + packages/*/package-lock.json + experimental/packages/*/node_modules + experimental/packages/*/package-lock.json + key: webworker-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 + + - name: Bootstrap + run: | + npm install --ignore-scripts + npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' + + - name: Build 🔧 + run: | + npm run compile + # run additional compilation variants + npx lerna run compile - name: Unit tests - run: npm run test:browser --scope @opentelemetry/core --include-dependencies - # - name: Report Coverage - # run: npm run codecov:browser - # webworker-tests: - # runs-on: ubuntu-latest - # container: - # image: circleci/node:16-browsers - # env: - # NPM_CONFIG_UNSAFE_PERM: true - # steps: - # - name: Permission Setup - # run: sudo chmod -R 777 /github /__w - # - name: Checkout - # uses: actions/checkout@v3.0.2 - - # - name: restore lerna - # id: cache - # uses: actions/cache@v3 - # with: - # path: | - # node_modules - # package-lock.json - # packages/*/node_modules - # packages/*/package-lock.json - # experimental/packages/*/node_modules - # experimental/packages/*/package-lock.json - # key: webworker-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 - - # - name: Bootstrap - # run: | - # npm install --ignore-scripts - # npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' - - # - name: Build 🔧 - # run: | - # npm run compile - # # run additional compilation variants - # npx lerna run compile - - # - name: Unit tests - # run: npm run test:webworker - # - name: Report Coverage - # run: npm run codecov:webworker + run: npm run test:webworker + - name: Report Coverage + run: npm run codecov:webworker From ae9bc2d81d0bd1d1c93adc09d1fdab30af2b4130 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:29:53 -0400 Subject: [PATCH 4/8] Apply to webworker tests --- .github/workflows/unit-test.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index c3cdfda722..0dd43be4a1 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -96,14 +96,12 @@ jobs: run: npm run test browser-tests: runs-on: ubuntu-latest - env: NPM_CONFIG_UNSAFE_PERM: true steps: - name: Checkout uses: actions/checkout@v3 - - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node_version }} @@ -128,8 +126,7 @@ jobs: - name: Build 🔧 run: | - # npm run compile - # run additional compilation variants + npx lerna run protos npx lerna run compile - name: Unit tests @@ -138,13 +135,9 @@ jobs: run: npm run codecov:browser webworker-tests: runs-on: ubuntu-latest - container: - image: circleci/node:16-browsers env: NPM_CONFIG_UNSAFE_PERM: true steps: - - name: Permission Setup - run: sudo chmod -R 777 /github /__w - name: Checkout uses: actions/checkout@v3.0.2 @@ -168,8 +161,7 @@ jobs: - name: Build 🔧 run: | - npm run compile - # run additional compilation variants + npx lerna run protos npx lerna run compile - name: Unit tests From c7c06f6a9ef7d49b327a6a7a527a88de33aaf619 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:31:57 -0400 Subject: [PATCH 5/8] Changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc96d88150..5af8762b41 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,8 @@ All notable changes to this project will be documented in this file. ### :house: (Internal) +* ci: run browser tests without circle [#3328](https://github.com/open-telemetry/opentelemetry-js/pull/3328) @dyladan + ## 1.7.0 ### :bug: (Bug Fix) From d4137abf0aabfda4b30943af1cc59097279eda17 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 11:54:31 -0400 Subject: [PATCH 6/8] Use specific node version --- .github/workflows/unit-test.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 0dd43be4a1..d57a598c4c 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -55,8 +55,6 @@ jobs: run: npm run codecov if: ${{ matrix.node_version == '14' }} node-windows-tests: - strategy: - fail-fast: false runs-on: windows-latest env: NPM_CONFIG_UNSAFE_PERM: true @@ -104,7 +102,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node_version }} + node-version: 18 - name: restore lerna id: cache @@ -140,6 +138,9 @@ jobs: steps: - name: Checkout uses: actions/checkout@v3.0.2 + - uses: actions/setup-node@v3 + with: + node-version: 18 - name: restore lerna id: cache From 74de346e5bcc04faa53efdbd8d8d842888b54f18 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 13:55:39 -0400 Subject: [PATCH 7/8] Review comments --- .github/workflows/unit-test.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index d57a598c4c..e9e9c94180 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -124,7 +124,6 @@ jobs: - name: Build 🔧 run: | - npx lerna run protos npx lerna run compile - name: Unit tests @@ -140,7 +139,7 @@ jobs: uses: actions/checkout@v3.0.2 - uses: actions/setup-node@v3 with: - node-version: 18 + node-version: 16 - name: restore lerna id: cache @@ -162,7 +161,6 @@ jobs: - name: Build 🔧 run: | - npx lerna run protos npx lerna run compile - name: Unit tests From 1aeac5aae6d834c8302723da6e5e5f8b64434b7d Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Thu, 13 Oct 2022 14:02:52 -0400 Subject: [PATCH 8/8] Downgrade node in both places --- .github/workflows/unit-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index e9e9c94180..7dea0d9044 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -102,7 +102,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: 18 + node-version: 16 - name: restore lerna id: cache