From 946f005940e1d923e9f3d326d8246a33c30205a6 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan Date: Thu, 20 Jan 2022 15:14:52 -0600 Subject: [PATCH 1/4] docs(otlp-grpc-exporter): update default url Signed-off-by: Svetlana Brennan --- packages/exporter-trace-otlp-grpc/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/exporter-trace-otlp-grpc/README.md b/packages/exporter-trace-otlp-grpc/README.md index f54acbe43b..b04a2cbb30 100644 --- a/packages/exporter-trace-otlp-grpc/README.md +++ b/packages/exporter-trace-otlp-grpc/README.md @@ -26,7 +26,7 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/sdk const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc'); const collectorOptions = { - // url is optional and can be omitted - default is grpc://localhost:4317 + // url is optional and can be omitted - default is localhost:4317 url: 'grpc://:', }; @@ -50,7 +50,7 @@ const { BasicTracerProvider, SimpleSpanProcessor } = require('@opentelemetry/sdk const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc'); const collectorOptions = { - // url is optional and can be omitted - default is grpc://localhost:4317 + // url is optional and can be omitted - default is localhost:4317 url: 'grpc://:', credentials: grpc.credentials.createSsl(), }; @@ -90,7 +90,7 @@ const metadata = new grpc.Metadata(); metadata.set('k', 'v'); const collectorOptions = { - // url is optional and can be omitted - default is grpc://localhost:4317 + // url is optional and can be omitted - default is localhost:4317 url: 'grpc://:', metadata, // // an optional grpc.Metadata object to be sent with each request }; From bd76a70a7a5999644b9653aa221cbea390e1adcf Mon Sep 17 00:00:00 2001 From: Svetlana Brennan Date: Tue, 25 Jan 2022 10:16:53 -0600 Subject: [PATCH 2/4] docs(otlp-grpc-exporter): update recommended url scheme Signed-off-by: Svetlana Brennan --- packages/exporter-trace-otlp-grpc/README.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/exporter-trace-otlp-grpc/README.md b/packages/exporter-trace-otlp-grpc/README.md index b04a2cbb30..80b39b320f 100644 --- a/packages/exporter-trace-otlp-grpc/README.md +++ b/packages/exporter-trace-otlp-grpc/README.md @@ -27,7 +27,8 @@ const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc' const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - url: 'grpc://:', + // if the provided url is schemeless, the exporter will add "https" as the scheme + url: ':', }; const provider = new BasicTracerProvider(); @@ -51,7 +52,8 @@ const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc' const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - url: 'grpc://:', + // if the provided url is schemeless, the exporter will add "https" as the scheme + url: ':', credentials: grpc.credentials.createSsl(), }; @@ -91,7 +93,8 @@ metadata.set('k', 'v'); const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - url: 'grpc://:', + // if the provided url is schemeless, the exporter will add "https" as the scheme + url: ':', metadata, // // an optional grpc.Metadata object to be sent with each request }; From 83377d396a603467b2b01adbaa59f0ef410e2b0b Mon Sep 17 00:00:00 2001 From: Svetlana Brennan Date: Tue, 25 Jan 2022 10:28:10 -0600 Subject: [PATCH 3/4] Merge branch 'fix-oltp-grpc-exporter-readme' of github.com:svetlanabrennan/opentelemetry-js into fix-oltp-grpc-exporter-readme From 8efc0c802b0e274bba99346e5da6aaec2a00fb23 Mon Sep 17 00:00:00 2001 From: Svetlana Brennan Date: Mon, 31 Jan 2022 14:39:01 -0600 Subject: [PATCH 4/4] docs(otlp-grpc-exporter): remove mention of default schemeless url Signed-off-by: Svetlana Brennan --- packages/exporter-trace-otlp-grpc/README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/exporter-trace-otlp-grpc/README.md b/packages/exporter-trace-otlp-grpc/README.md index 80b39b320f..85e7b66316 100644 --- a/packages/exporter-trace-otlp-grpc/README.md +++ b/packages/exporter-trace-otlp-grpc/README.md @@ -27,7 +27,6 @@ const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc' const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - // if the provided url is schemeless, the exporter will add "https" as the scheme url: ':', }; @@ -52,7 +51,6 @@ const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc' const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - // if the provided url is schemeless, the exporter will add "https" as the scheme url: ':', credentials: grpc.credentials.createSsl(), }; @@ -93,7 +91,6 @@ metadata.set('k', 'v'); const collectorOptions = { // url is optional and can be omitted - default is localhost:4317 - // if the provided url is schemeless, the exporter will add "https" as the scheme url: ':', metadata, // // an optional grpc.Metadata object to be sent with each request };