From 6eb262a7ed9912569438f2124beb748d6170839b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerhard=20St=C3=B6bich?= <18708370+Flarna@users.noreply.github.com> Date: Fri, 30 Jul 2021 12:44:14 +0200 Subject: [PATCH 1/2] chore: move api into dependencies in integration tests Integration tests require the OTel API. Therefore move it into dependencies section and remove the peer-dependency. --- integration-tests/propagation-validation-server/package.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/integration-tests/propagation-validation-server/package.json b/integration-tests/propagation-validation-server/package.json index a656ca67f4..c99964daa4 100644 --- a/integration-tests/propagation-validation-server/package.json +++ b/integration-tests/propagation-validation-server/package.json @@ -11,6 +11,7 @@ "compile": "tsc --build" }, "dependencies": { + "@opentelemetry/api": "^1.0.1", "@opentelemetry/context-async-hooks": "0.24.0", "@opentelemetry/core": "0.24.0", "@opentelemetry/tracing": "0.24.0", @@ -19,10 +20,6 @@ "express": "4.17.1" }, "devDependencies": { - "@opentelemetry/api": "^1.0.1", "typescript": "4.3.5" - }, - "peerDependencies": { - "@opentelemetry/api": "^1.0.1" } } From d1cd04360c9734d18684c88e5f0bd940f12378c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerhard=20St=C3=B6bich?= <18708370+Flarna@users.noreply.github.com> Date: Fri, 30 Jul 2021 13:01:00 +0200 Subject: [PATCH 2/2] exclude propagation-validation-server from peer API check --- .github/workflows/peer-api.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/peer-api.yaml b/.github/workflows/peer-api.yaml index d1995d86e5..2eeafe1d92 100644 --- a/.github/workflows/peer-api.yaml +++ b/.github/workflows/peer-api.yaml @@ -19,4 +19,4 @@ jobs: run: npm install -g lerna - name: Check API dependency semantics - run: lerna exec "node ../../scripts/peer-api-check.js" + run: lerna exec --ignore propagation-validation-server "node ../../scripts/peer-api-check.js"