-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alibaba cloud (aliyun) detector #2378
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
+ Coverage 92.36% 92.81% +0.45%
==========================================
Files 128 147 +19
Lines 4244 5263 +1019
Branches 867 1071 +204
==========================================
+ Hits 3920 4885 +965
- Misses 324 378 +54
|
52cc141
to
87d68b0
Compare
I think this should be moved to the contrib repo. I know AWS and GCP is also on this repo but actually they should be also moved. |
I guess it's just a matter of waiting on someone actually doing it. I would not combine your PR with the move as this just complicates the review process. Lets wait if the maintainers come up with a guideline if/where in contrib the detectors should be located and maybe also regarding the timeline. |
@@ -480,6 +480,8 @@ As an alternative, consider setting `faas.id` as a span attribute instead. | |||
|
|||
|
|||
export enum CloudProviderValues { | |||
/** Alibaba Cloud. */ | |||
ALIYUN = 'aliyun', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a generated file. I guess the place to update this is in spec repo: https://github.com/open-telemetry/opentelemetry-specification/blob/main/semantic_conventions/resource/cloud.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now you can just add const for that inside the package you are adding
you can add new detector here -> https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/detectors/node , moving other detectors - separate PR, I think we should do this yet before GA |
@obecny thanks for the suggestion. I'll do it with separate PRs. |
Which problem is this PR solving?
Short description of the changes