From cf415d3ce7cf7427fdadaccded7ebea826a9c6d9 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Wed, 10 Jun 2020 10:06:49 -0400 Subject: [PATCH 1/5] feat: add node-plugins-all package --- metapackages/plugins-node-all/README.md | 47 ++++++++++++++++++++++ metapackages/plugins-node-all/package.json | 28 +++++++++++++ 2 files changed, 75 insertions(+) create mode 100644 metapackages/plugins-node-all/README.md create mode 100644 metapackages/plugins-node-all/package.json diff --git a/metapackages/plugins-node-all/README.md b/metapackages/plugins-node-all/README.md new file mode 100644 index 0000000000..665b210dac --- /dev/null +++ b/metapackages/plugins-node-all/README.md @@ -0,0 +1,47 @@ +# OpenTelemetry Plugins Node Core +[![Gitter chat][gitter-image]][gitter-url] +[![NPM Published Version][npm-img]][npm-url] +[![dependencies][dependencies-image]][dependencies-url] +[![Apache License][license-image]][license-image] + +This package depends on all core node plugins maintained by OpenTelemetry authors. Installing it installs all core plugins + +## Plugins + +In addition to all [node core plugins][otel-plugins-node-core], the following plugins will be installed by this package + +- [@opentelemetry/plugin-express][otel-plugin-express] +- [@opentelemetry/plugin-ioredis][otel-plugin-ioredis] +- [@opentelemetry/plugin-mongodb][otel-plugin-mongodb] +- [@opentelemetry/plugin-mysql][otel-plugin-mysql] +- [@opentelemetry/plugin-pg-pool][otel-plugin-pg-pool] +- [@opentelemetry/plugin-pg][otel-plugin-pg] +- [@opentelemetry/plugin-redis][otel-plugin-redis] + +note: dns is excluded by default because it requires some manual configuration to prevent infinite loops with exporters. + +## Useful links +- For more information on OpenTelemetry, visit: +- For more about OpenTelemetry JavaScript: +- For help or feedback on this project, join us on [gitter][gitter-url] + +## License + +Apache 2.0 - See [LICENSE][license-url] for more information. + +[gitter-image]: https://badges.gitter.im/open-telemetry/opentelemetry-js.svg +[gitter-url]: https://gitter.im/open-telemetry/opentelemetry-node?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge +[license-url]: https://github.com/open-telemetry/opentelemetry-js/blob/master/LICENSE +[license-image]: https://img.shields.io/badge/license-Apache_2.0-green.svg?style=flat +[dependencies-image]: https://david-dm.org/open-telemetry/opentelemetry-js/status.svg?path=metapackages/plugins-node-core +[dependencies-url]: https://david-dm.org/open-telemetry/opentelemetry-js?path=packages%2Fopentelemetryplugins-node-core +[npm-url]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core +[npm-img]: https://badge.fury.io/js/%40opentelemetry%2Fplugins-node-core.svg + +[otel-plugin-express]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-express +[otel-plugin-ioredis]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-ioredis +[otel-plugin-mongodb]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-mongodb +[otel-plugin-mysql]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-mysql +[otel-plugin-pg-pool]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-pg-pool +[otel-plugin-pg]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-pg +[otel-plugin-redis]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-redis diff --git a/metapackages/plugins-node-all/package.json b/metapackages/plugins-node-all/package.json new file mode 100644 index 0000000000..24292e3a99 --- /dev/null +++ b/metapackages/plugins-node-all/package.json @@ -0,0 +1,28 @@ +{ + "name": "@opentelemetry/plugins-node-all", + "version": "0.8.3", + "description": "Metapackage which bundles all opentelemetry node core and contrib plugins", + "author": "OpenTelemetry Authors", + "homepage": "https://github.com/open-telemetry/opentelemetry-js#readme", + "license": "Apache-2.0", + "publishConfig": { + "access": "public" + }, + "repository": { + "type": "git", + "url": "git+https://github.com/open-telemetry/opentelemetry-js.git" + }, + "bugs": { + "url": "https://github.com/open-telemetry/opentelemetry-js/issues" + }, + "dependencies": { + "@opentelemetry/plugins-node-core": "^0.8.3", + "@opentelemetry/plugin-express": "0.8.0", + "@opentelemetry/plugin-ioredis": "0.8.0", + "@opentelemetry/plugin-mongodb": "0.8.0", + "@opentelemetry/plugin-mysql": "0.8.0", + "@opentelemetry/plugin-pg-pool": "0.8.0", + "@opentelemetry/plugin-pg": "0.8.0", + "@opentelemetry/plugin-redis": "0.8.0" + } +} From ade2df914e7e588e6eb6043f909ba9bb48fdbdcf Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Wed, 10 Jun 2020 14:46:04 -0400 Subject: [PATCH 2/5] chore: grammar fixes --- metapackages/plugins-node-all/README.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/metapackages/plugins-node-all/README.md b/metapackages/plugins-node-all/README.md index 665b210dac..65fd83656c 100644 --- a/metapackages/plugins-node-all/README.md +++ b/metapackages/plugins-node-all/README.md @@ -4,11 +4,12 @@ [![dependencies][dependencies-image]][dependencies-url] [![Apache License][license-image]][license-image] -This package depends on all core node plugins maintained by OpenTelemetry authors. Installing it installs all core plugins +This package depends on all node plugins maintained by OpenTelemetry authors. +Installing it will also install all plugins. ## Plugins -In addition to all [node core plugins][otel-plugins-node-core], the following plugins will be installed by this package +In addition to all [node core plugins][otel-plugins-node-core], the following plugins will be installed by this package: - [@opentelemetry/plugin-express][otel-plugin-express] - [@opentelemetry/plugin-ioredis][otel-plugin-ioredis] @@ -18,7 +19,7 @@ In addition to all [node core plugins][otel-plugins-node-core], the following pl - [@opentelemetry/plugin-pg][otel-plugin-pg] - [@opentelemetry/plugin-redis][otel-plugin-redis] -note: dns is excluded by default because it requires some manual configuration to prevent infinite loops with exporters. +Note: [@opentelemetry/plugin-dns][otel-plugin-dns] is excluded by default because it requires some manual configuration to prevent infinite loops with exporters. ## Useful links - For more information on OpenTelemetry, visit: @@ -38,6 +39,7 @@ Apache 2.0 - See [LICENSE][license-url] for more information. [npm-url]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core [npm-img]: https://badge.fury.io/js/%40opentelemetry%2Fplugins-node-core.svg +[otel-plugin-dns]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-dns [otel-plugin-express]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-express [otel-plugin-ioredis]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-ioredis [otel-plugin-mongodb]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-mongodb From 0298eccb3f8f112147c98e7a6375c93b41f45018 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Wed, 10 Jun 2020 14:47:22 -0400 Subject: [PATCH 3/5] chore: add missing url --- metapackages/plugins-node-all/README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/metapackages/plugins-node-all/README.md b/metapackages/plugins-node-all/README.md index 65fd83656c..3b63827b5b 100644 --- a/metapackages/plugins-node-all/README.md +++ b/metapackages/plugins-node-all/README.md @@ -39,6 +39,8 @@ Apache 2.0 - See [LICENSE][license-url] for more information. [npm-url]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core [npm-img]: https://badge.fury.io/js/%40opentelemetry%2Fplugins-node-core.svg +[otel-plugins-node-core]: https://www.npmjs.com/package/@opentelemetry/plugins-node-core + [otel-plugin-dns]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-dns [otel-plugin-express]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-express [otel-plugin-ioredis]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-ioredis From e742b8aaee46f6ef9d93c8b88555cedf0ab5dc5a Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Fri, 12 Jun 2020 08:19:23 -0400 Subject: [PATCH 4/5] chore: add missing carat --- metapackages/plugins-node-all/package.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/metapackages/plugins-node-all/package.json b/metapackages/plugins-node-all/package.json index 24292e3a99..d33f0c9a62 100644 --- a/metapackages/plugins-node-all/package.json +++ b/metapackages/plugins-node-all/package.json @@ -17,12 +17,12 @@ }, "dependencies": { "@opentelemetry/plugins-node-core": "^0.8.3", - "@opentelemetry/plugin-express": "0.8.0", - "@opentelemetry/plugin-ioredis": "0.8.0", - "@opentelemetry/plugin-mongodb": "0.8.0", - "@opentelemetry/plugin-mysql": "0.8.0", - "@opentelemetry/plugin-pg-pool": "0.8.0", - "@opentelemetry/plugin-pg": "0.8.0", - "@opentelemetry/plugin-redis": "0.8.0" + "@opentelemetry/plugin-express": "^0.8.0", + "@opentelemetry/plugin-ioredis": "^0.8.0", + "@opentelemetry/plugin-mongodb": "^0.8.0", + "@opentelemetry/plugin-mysql": "^0.8.0", + "@opentelemetry/plugin-pg-pool": "^0.8.0", + "@opentelemetry/plugin-pg": "^0.8.0", + "@opentelemetry/plugin-redis": "^0.8.0" } } From 2abf5889196b0e482e65540767ce2cf552c48873 Mon Sep 17 00:00:00 2001 From: Daniel Dyla Date: Wed, 17 Jun 2020 13:32:40 -0400 Subject: [PATCH 5/5] chore: remove 'all' nit --- metapackages/plugins-node-all/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/metapackages/plugins-node-all/package.json b/metapackages/plugins-node-all/package.json index d33f0c9a62..e1377a972c 100644 --- a/metapackages/plugins-node-all/package.json +++ b/metapackages/plugins-node-all/package.json @@ -1,7 +1,7 @@ { "name": "@opentelemetry/plugins-node-all", "version": "0.8.3", - "description": "Metapackage which bundles all opentelemetry node core and contrib plugins", + "description": "Metapackage which bundles opentelemetry node core and contrib plugins", "author": "OpenTelemetry Authors", "homepage": "https://github.com/open-telemetry/opentelemetry-js#readme", "license": "Apache-2.0",