Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter-collector: proto files are missing from NPM package #995

Closed
jordanworner opened this issue Apr 29, 2020 · 4 comments
Closed

exporter-collector: proto files are missing from NPM package #995

jordanworner opened this issue Apr 29, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jordanworner
Copy link
Contributor

What version of OpenTelemetry are you using?

0.7.0

What version of Node are you using?

v12.16.2

What did you do?

Updated @opentelemetry/exporter-collector to 0.7.0

What did you expect to see?

No errors

What did you see instead?

Warning: opentelemetry/proto/collector/trace/v1/trace_service.proto not found in any of the include paths node_modules/@opentelemetry/exporter-collector/build/src/platform/node/protos

Additional context

Looks like the package.json wasn't updated to include the .proto files in the published package

"files": [
  "build/src/**/*.js",
  "build/src/**/*.d.ts",
  "doc",
  "LICENSE",
  "README.md"
]
@jordanworner jordanworner added the bug Something isn't working label Apr 29, 2020
@obecny
Copy link
Member

obecny commented May 20, 2020

#1053

@obecny
Copy link
Member

obecny commented May 20, 2020

fixed in 0.8.1

@obecny obecny closed this as completed May 20, 2020
@dyladan
Copy link
Member

dyladan commented May 20, 2020

@jordanworner pls confirm 0.8.1 working if you get a chance.

@jordanworner
Copy link
Contributor Author

@dyladan 0.8.1 LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants