Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource API #789

Closed
OlivierAlbertini opened this issue Feb 18, 2020 · 0 comments
Closed

Add Resource API #789

OlivierAlbertini opened this issue Feb 18, 2020 · 0 comments
Assignees
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Milestone

Comments

@OlivierAlbertini
Copy link
Member

From #788 (comment)
We should implement Resource API specs.

Describe the solution you'd like

Implementing following specs:

  1. https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/data-resource-semantic-conventions.md#version-attributes
  2. https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-resource.md

I believe that it should have it's own package with opentelemetry/api deps.
Also in order to be sure that attributes is spec conform, we should provide function that would check
all naming convention rules (1.) for a specific Resource. This function would be used in all plugins during tests (perhaps some automation could be done but not mandatory).

Describe alternatives you've considered
Stay as is.

Please add any thoughs / Diagrams on how you see this.

@OlivierAlbertini OlivierAlbertini added feature-request API Discussion Issue or PR that needs/is extended discussion. labels Feb 18, 2020
@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Feb 18, 2020
@mayurkale22 mayurkale22 added this to the Beta milestone Feb 18, 2020
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Feb 19, 2020
@dyladan dyladan mentioned this issue Feb 19, 2020
46 tasks
@dyladan dyladan closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion. feature-request
Projects
None yet
Development

No branches or pull requests

4 participants