Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opentelemetry/semantic-conventions out of sync. E.g. 1.25.1 http.user_agent does not follow semantic conventions? #4843

Closed
AkselAllas opened this issue Jul 2, 2024 · 4 comments
Labels
bug Something isn't working triage

Comments

@AkselAllas
Copy link
Contributor

What happened?

In semantic-conventions 1.19.0 there is this line:

Rename http.user_agent to user_agent.original

But I have span from instrumentation-http 0.52.1, which uses 1.25.1 of @opentelemetry/semantic_conventions with http.user_agent (defined here) which is not what semantic convention defines?

Am I misunderstanding something on how these versions are supposed to work?

Span:
image

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response

@AkselAllas AkselAllas added bug Something isn't working triage labels Jul 2, 2024
@AkselAllas AkselAllas changed the title @opentelemetry/semantic_conventions 1.25.1 http.user_agent does not follow semantic conventions? @opentelemetry/semantic-conventions 1.25.1 http.user_agent does not follow semantic conventions? Jul 2, 2024
@AkselAllas
Copy link
Contributor Author

Seems semantic-conventions is in violation of this line from docs:

The YAML files MUST be used as the source of truth for generation.

@AkselAllas AkselAllas changed the title @opentelemetry/semantic-conventions 1.25.1 http.user_agent does not follow semantic conventions? @opentelemetry/semantic-conventions out of sync. E.g. 1.25.1 http.user_agent does not follow semantic conventions? Jul 2, 2024
@pichlermarc
Copy link
Member

Hi, thanks for reaching out.

Seems semantic-conventions is in violation of this line from docs:

The YAML files MUST be used as the source of truth for generation.

The semantic conventions are out of date, but they do follow the YAML - just a very, very old verison of it. @dyladan is working on updating them. See #4572, #4690, it's a rather complex situation as we released 1.x which exported experimental attributes as stable, so we can't just drop these.

This issue is a possible duplicate of #4572

@AkselAllas
Copy link
Contributor Author

AkselAllas commented Jul 8, 2024

I just wanted to say that as an outside viewer, I expected 1.25.1 release of semantic-conventions to actually follow the YAML of 1.25.1 version.

@JamieDanielson
Copy link
Member

I just wanted to say that as an outside viewer, I expected 1.25.1 release of semantic-conventions to actually follow the YAML of 1.25.1 version.

That is a fair point. In fact since we are working on semantic conventions now and the version numbers are close to matching up, I think we are going to separate the publishing of the semantic conventions package so we have more control over the version number. This will hopefully make it more clear going forward.

In the meantime I will close this issue as a duplicate being tracked elsewhere for updating semantic conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

3 participants