Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Do not report metric data for previosuly observed attribute sets that were not observed during the current cycle #4096

Open
Tracked by #5135
pichlermarc opened this issue Aug 30, 2023 · 0 comments
Labels
bug Something isn't working needs:code-contribution This feature/bug is ready to implement pkg:sdk-metrics priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Aug 30, 2023

Description

Currently, we do keep reporting even if the callback has been registered and no observations do take place (see #2997 (comment))

However, the spec states:

The implementation SHOULD NOT produce aggregated metric data for a
previously-observed attribute set which is not observed during a successful
callback.

Describe the solution you'd like

Implement the specification.

Additional resources

@pichlermarc pichlermarc added bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug labels Aug 30, 2023
@pichlermarc pichlermarc added pkg:sdk-metrics needs:code-contribution This feature/bug is ready to implement labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs:code-contribution This feature/bug is ready to implement pkg:sdk-metrics priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect spec-noncompliant An existing feature incorrectly or incompletely implements the OTel spec. May or may not be a bug
Projects
None yet
Development

No branches or pull requests

1 participant