Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Implement experimenal cardinality limit specification #4095

Closed
1 task done
Tracked by #5135
pichlermarc opened this issue Aug 30, 2023 · 1 comment
Closed
1 task done
Tracked by #5135
Labels
needs:code-contribution This feature/bug is ready to implement never-stale pkg:sdk-metrics sdk:metrics Issues and PRs related to the Metrics SDK spec-feature This is a request to implement a new feature which is already specified by the OTel specification type:feature A feature with no sub-issues to address

Comments

@pichlermarc
Copy link
Member

pichlermarc commented Aug 30, 2023

Description

Currently, metrics will allocate one metric stream per attribute configuration, which means that a single attribute with an unbounded amount of values can cause a memory leak.

The Metrics SDK specification defines experimental cardinality limits that SDKs can implement. These limits allow us to forget stale metric streams.

This issue is considered done when

Additional context

@pichlermarc pichlermarc added feature-request never-stale spec-feature This is a request to implement a new feature which is already specified by the OTel specification sdk:metrics Issues and PRs related to the Metrics SDK pkg:sdk-metrics labels Aug 30, 2023
@pichlermarc pichlermarc added type:feature A feature with no sub-issues to address needs:code-contribution This feature/bug is ready to implement and removed feature-request labels Oct 25, 2024
@pichlermarc
Copy link
Member Author

Implemented in #5128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-contribution This feature/bug is ready to implement never-stale pkg:sdk-metrics sdk:metrics Issues and PRs related to the Metrics SDK spec-feature This is a request to implement a new feature which is already specified by the OTel specification type:feature A feature with no sub-issues to address
Projects
None yet
Development

No branches or pull requests

1 participant