NodeSDK constructor not using defaultAttributes from NodeSDKConfiguration

[zvickery]

What happened?

defaultAttributes setting in the NodeSDK constructor doesn't seem to do anything. Should it be there at all?

Steps to Reproduce

Initialize the SDK with default attributes set, like below:

const sdk = new NodeSDK({
    defaultAttributes: { ['testing']: '123' },
    ...
});

Expected Result

Provided attributes added to resulting auto-instrumented OTel Traces

Actual Result

Nothing happens

Additional Details

From the documentation and types I assumed we could set defaultAttributes to get extra attributes injected into the tracer. My intent is to add some attributes for searching across auto-instrumented traces. However this doesn't work because the code doesn't use defaultAttributes at all: https://github.com/open-telemetry/opentelemetry-js/blob/main/experimental/packages/opentelemetry-sdk-node/src/sdk.ts#L90

Generally speaking, there doesn't seem to be any other plumbing for this that I could see in the SDK. Is the defaultAttributes functionality supposed to work? Or is there another way to do this?

OpenTelemetry Setup Code

// I just invoke the NodeSDK constructor with standard setup code.  All is working well except I
// cannot add extra attributes to auto-instrumented traces

package.json

No response

Relevant log output

No response

[Flarna]

I think it should be removed.
I assume this is some leftover because parts of OTel were based on OpenTracing/OpenCensus. As far as I remember default attributes have been replaced by resource attributes.

I removed something similar in OTLP exporters a while ago: #2991

[pichlermarc]

Yep, that looks like a leftover, this can be done with Resource now.
I'll open a PR.