Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP instrumentation modifies headers casing of outgoing requests #3556

Closed
marcinjahn opened this issue Jan 21, 2023 · 0 comments · Fixed by #3557
Closed

HTTP instrumentation modifies headers casing of outgoing requests #3556

marcinjahn opened this issue Jan 21, 2023 · 0 comments · Fixed by #3557
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@marcinjahn
Copy link
Contributor

What happened?

It's about the package @opentelemetry/instrumentation-http.

The http auto-instrumentation should not modify the request in any other way than context injection. Currently, the library does modify the casing of request headers. Even though in theory that should not matter, there are servers that require incoming headers to have some predefined casing, e.g. all letters uppercase.

This behavior potentially (and in practice too, as I was able to experience that :)) breaks applications that would work completely fine before installing http instrumentation.

Steps to Reproduce

Try to send an HTTP request with header: { MY_HEADER: 123 }

Expected Result

The target server should receive a request with header { MY_HEADER: 123 }.

Actual Result

The target server receives a request with header { my_header: 123 }.

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response

@marcinjahn marcinjahn added bug Something isn't working triage labels Jan 21, 2023
@marcinjahn marcinjahn changed the title HTTP instrumentation modifies headers casing o outgoing requests HTTP instrumentation modifies headers casing of outgoing requests Jan 24, 2023
@dyladan dyladan added priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect and removed triage labels Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants