Please, add http.target and http.url to metric attributes

[mkrudele]

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.

Is your feature request related to a problem? Please describe.

http_server_duration is missing http_target attribute.
http_client_duration is missing the http_url attribute.
Both are crucial to build effective monitoring dashboards and alerting system.

Looking at the code I see TODOs here:

opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts

Line 384 in 652d167

//TODO: http.url attribute, it should susbtitute any parameters to avoid high cardinality.

and here

opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts

Line 524 in 652d167

//TODO: http.target attribute, it should susbtitute any parameters to avoid high cardinality.

.

Describe the solution you'd like

We are using prometheus exporter to send metrics to our Syddig instance. As wrote above, we need the http.target and http.url in server and client metrics to build really useful monitoring dashboards and alerting system.

Describe alternatives you've considered

We want to use OpenTelemetry, so not yet considered alternatives.

Additional context

[mkrudele]

I also noticed that the http_target does not include request query parameters. Would it be possible to add an additional attribute, e.g. http_search_params for that?

[hermogenes]

I also noticed that the http_target does not include request query parameters. Would it be possible to add an additional attribute, e.g. http_search_params for that?

Hello @mkrudele! Are you sure that is a good idea add query params to metrics? I think it would make the lib prone to high cardinality problems. Maybe an option would be introduce a hook similar to the ones available to span and allow customize the metric on demand

[mkrudele]

@hermogenes I agree, I didn't think at that aspect. A hook would work, however you added the most important piece of information actually missing, the HTTP_ROUTE, which is great. Thank you. I hope it will be published soon in a new release.

[mkrudele]

@hermogenes Any idea of when will this be published in a new release?