Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated webpack version for selenium-tests #3456

Merged
merged 7 commits into from
Dec 13, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Nov 30, 2022

workerB

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3397
#3397

Short description of the changes

Selenium tests are currently not working. This is seemingly due to the config being written for webpack v5+

Type of change

fixed by using the following webpack versions:

"webpack": "^5.60.0",
"webpack-cli": "^4.10.0",
"webpack-dev-server": "^4.5.0",
"webpack-merge": "^5.8.0"

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@SaumyaBhushan SaumyaBhushan requested a review from a team November 30, 2022 12:58
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3456 (b33a9da) into main (6410ca1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b33a9da differs from pull request most recent head 8b16e8c. Consider uploading reports for the commit 8b16e8c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3456      +/-   ##
==========================================
- Coverage   93.77%   93.76%   -0.02%     
==========================================
  Files         248      248              
  Lines        7567     7567              
  Branches     1580     1580              
==========================================
- Hits         7096     7095       -1     
- Misses        471      472       +1     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to work on this 🙂
Just one comment from my side and we can get this over the finish line 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marc Pichler <[email protected]>
@SaumyaBhushan
Copy link
Contributor Author

SaumyaBhushan commented Dec 13, 2022

Thanks for taking the time to work on this slightly_smiling_face Just one comment from my side and we can get this over the finish line slightly_smiling_face

thanks @pichlermarc for your suggestions . I have committed those suggestions. please have a review.

@pichlermarc
Copy link
Member

pichlermarc commented Dec 13, 2022

Thanks @SaumyaBhushan, please also move the changelog entry to the unreleased section 🙂

@SaumyaBhushan
Copy link
Contributor Author

Thanks @SaumyaBhushan, please also move the changelog entry to the unreleased section slightly_smiling_face

Done @pichlermarc

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙂

@legendecas legendecas merged commit 263ee61 into open-telemetry:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong webpack version causes selenium-tests to fail locally
4 participants