-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated webpack version for selenium-tests #3456
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3456 +/- ##
==========================================
- Coverage 93.77% 93.76% -0.02%
==========================================
Files 248 248
Lines 7567 7567
Branches 1580 1580
==========================================
- Hits 7096 7095 -1
- Misses 471 472 +1
|
Signed-off-by: SaumyaBhushan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to work on this 🙂
Just one comment from my side and we can get this over the finish line 🙂
Co-authored-by: Marc Pichler <[email protected]>
thanks @pichlermarc for your suggestions . I have committed those suggestions. please have a review. |
Thanks @SaumyaBhushan, please also move the changelog entry to the unreleased section 🙂 |
Done @pichlermarc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙂
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3397
#3397
Short description of the changes
Selenium tests are currently not working. This is seemingly due to the config being written for webpack v5+
Type of change
fixed by using the following webpack versions:
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: