Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build of the project will not compile #3344

Closed
dyladan opened this issue Oct 19, 2022 · 2 comments · Fixed by #3347
Closed

Clean build of the project will not compile #3344

dyladan opened this issue Oct 19, 2022 · 2 comments · Fixed by #3347
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc

Comments

@dyladan
Copy link
Member

dyladan commented Oct 19, 2022

What happened?

Steps to Reproduce

git clone [email protected]:open-telemetry/opentelemetry-js.git
cd opentelemetry-js
npm install
npm run compile

Observe that the project does not compile with the following failure:

error TS2688: Cannot find type definition file for 'keyv'.
  The file is in the program because:
    Entry point for implicit type library 'keyv'

OpenTelemetry Setup Code

No response

package.json

No response

Relevant log output

No response

@dyladan dyladan added bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc labels Oct 19, 2022
@dyladan dyladan pinned this issue Oct 19, 2022
@dyladan dyladan mentioned this issue Oct 19, 2022
7 tasks
@dyladan
Copy link
Member Author

dyladan commented Oct 19, 2022

Doing some spelunking into the project dependency resolution.

Seems like keyv is required by cacheable-request which is required by got. Some update to either cacheable-request or keyv broke the type checking. Most recent release of cacheable-request was almost a month ago so that seems unlikely. Most recent release of keyv was 2 days ago so that may have caused it. In that release they made some typescript changes including updating their typescript compiler so it seems likely that caused our issue.

got's most recent release was ~7 days ago https://github.com/sindresorhus/got/releases/tag/v12.5.2

Testing to see if removing got (only used in tests for http instrumentation) fixes our issue.

@legendecas
Copy link
Member

As this has been fixed, I'm unpinning this issue.

@legendecas legendecas unpinned this issue Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p1 Bugs which cause problems in end-user applications such as crashes, data inconsistencies, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants