-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP exporters should set User-Agent header as per specification #3291
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
not stale & working on this. |
@pichlermarc See open-telemetry/opentelemetry-specification#3052 for the corrected format. |
@pichlermarc any update? |
Thanks!
@dyladan No, not yet. I did not have time to work on that for a while. Also, it's not a single line change unfortunately. Edit: I was not assigned. 😅 Added back the "up-for-grabs" label. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
The header is set for all Node.js exporters as of #4397, but still missing for browser exporters. It would probably make sense to centralize the logic in the |
@raphael-theriault-swi yep - thanks for pointing that out, I completely forgot about this issue. We don't set the User-Agent it used to be prohibited, but it will still lead to error logs in some browsers so we opted not to do it. I'm closing this issue as we can consider it done :) |
Is your feature request related to a problem? Please describe.
Currently the
User-Agent
header is not set by our exporters as defined in the specification.Describe the solution you'd like
The
User-Agent
Header should be added asOTel OTLP Exporter JavaScript/<exporter version>
in all OTLP exporters.Additional context
Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#user-agent
The text was updated successfully, but these errors were encountered: