You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Some exporters README's mention that the maxExportBatchSize setting of the BatchSpanProcessor must be maller or equal to maxQueueSize. But no validation is performed in code.
It's difficult to track the correctness of the values by hand, because one of the values can be modified and another use default...
Describe the solution you'd like
Perhaps the safest solution would be to write warning to logs and use default values if supplied settings are invalid
Describe alternatives you've considered
Another solution is to throw an error from the constructor. But this is a breaking change and unsafe
Additional context
We tried to add validation in application logic, but it's impossible, because we can't know default values for sure.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Some exporters README's mention that the
maxExportBatchSize
setting of theBatchSpanProcessor
must be maller or equal tomaxQueueSize
. But no validation is performed in code.It's difficult to track the correctness of the values by hand, because one of the values can be modified and another use default...
Describe the solution you'd like
Perhaps the safest solution would be to write warning to logs and use default values if supplied settings are invalid
Describe alternatives you've considered
Another solution is to throw an error from the constructor. But this is a breaking change and unsafe
Additional context
We tried to add validation in application logic, but it's impossible, because we can't know default values for sure.
The text was updated successfully, but these errors were encountered: