Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend tests to test node 18 #2935

Closed
dyladan opened this issue Apr 27, 2022 · 5 comments
Closed

Extend tests to test node 18 #2935

dyladan opened this issue Apr 27, 2022 · 5 comments
Assignees
@Keimille
Labels
good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Apr 27, 2022

Node 18 is officially released. The CI should be updated to test it and node 16 should be added to the backwards-compatiblity tests.
@dyladan dyladan added up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Apr 27, 2022
@Keimille
Copy link

@dyladan just attended the SIG for the first time and looking to get involved. I can take this one, if that is okay.

@dyladan
Copy link
Member Author

dyladan commented Apr 27, 2022

Perfect! Assigned you

@Keimille
Copy link

Keimille commented May 1, 2022

I've extended tests for node 18. But npm install breaks with node 18. Should investigating this be a part of this issue? Don't mind digging in further and including fixes in the PR.

@Keimille Keimille mentioned this issue May 3, 2022
Closed
@dyladan
Copy link
Member Author

dyladan commented May 4, 2022

Yes that is part of the issue

@legendecas
Copy link
Member

Closing as #3048 has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keimille Keimille

Labels
good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds node18 to node_version matrix to enable node18 test Keimille/opentelemetry-js
3 participants
@dyladan @legendecas @Keimille