-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Extract basic packages for otlp exporters #2665
Comments
We discussed in the past that it might be better to refactor those packages so this is more than welcome, i don't see an issue with your proposal and looking for your PR :)
We already discussed on the naming for package that will be consumed by users so those won't changes, apart from base package names are fine |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@legendecas you linked my PR to this but I don't believe my PR fully addresses this but is really just a prerequisite |
@dyladan sorry about miscategorization. please feel free to remove the link. |
Ah looks like I missed this issue back then. Done in #2893 🙂 |
The current dependency graph of otlp exporters does not look reasonable:
exporter-trace-otlp-http
package.Here I propose to extract some basic packages to make the structure better:
I.e., add some base packages.
Those base packages are "abstract packages", users could not use them directly. Those packages are only used to be extended from. It should also be helpful when we have
exporter-logs-otlp-xxx
in the future.If this proposal is going to be accepted, I could open a PR for it. In fact, I've already started trying to refactor them, but it will affect at least 10 packages, so I think it's better to open an issue and ask for comments first.
BTW, any suggestions about the naming of those packages?
The text was updated successfully, but these errors were encountered: