Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package template node engine version #2318

Closed
jonchurch opened this issue Jul 2, 2021 · 0 comments · Fixed by #2319
Closed

Package template node engine version #2318

jonchurch opened this issue Jul 2, 2021 · 0 comments · Fixed by #2319

Comments

@jonchurch
Copy link
Contributor

jonchurch commented Jul 2, 2021

Currently in the package template package.json the engines field is set to >=8.0.0. Should this be >=8.5.0, to be in line with the current Node support range for OTLP?

I'm submitting a PR to address this, because I figure the answer is yes.

Edit: Okay, so most (all?) of the packages list >=8.0.0 in the engines field in their package.json. (opentelemetry-instrumentation-http, for example)

Curious if I'm missing context here. For clarity, the engines field doesn't prevent anyone from running them at whatever version they please, it just generates a warning. Having those fields accurate though is useful for machines and statistics pulled from the NPM registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant