You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in the package template package.json the engines field is set to >=8.0.0. Should this be >=8.5.0, to be in line with the current Node support range for OTLP?
I'm submitting a PR to address this, because I figure the answer is yes.
Edit: Okay, so most (all?) of the packages list >=8.0.0 in the engines field in their package.json. (opentelemetry-instrumentation-http, for example)
Curious if I'm missing context here. For clarity, the engines field doesn't prevent anyone from running them at whatever version they please, it just generates a warning. Having those fields accurate though is useful for machines and statistics pulled from the NPM registry.
The text was updated successfully, but these errors were encountered:
Currently in the package template package.json the engines field is set to
>=8.0.0
. Should this be>=8.5.0
, to be in line with the current Node support range for OTLP?I'm submitting a PR to address this, because I figure the answer is yes.
Edit: Okay, so most (all?) of the packages list >=8.0.0 in the engines field in their package.json. (opentelemetry-instrumentation-http, for example)
Curious if I'm missing context here. For clarity, the engines field doesn't prevent anyone from running them at whatever version they please, it just generates a warning. Having those fields accurate though is useful for machines and statistics pulled from the NPM registry.
The text was updated successfully, but these errors were encountered: