Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated docs in opentelemetry-resources #2284

Closed
morigs opened this issue Jun 15, 2021 · 0 comments · Fixed by #2289
Closed

Outdated docs in opentelemetry-resources #2284

morigs opened this issue Jun 15, 2021 · 0 comments · Fixed by #2289
Labels
document Documentation-related up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@morigs
Copy link
Contributor

morigs commented Jun 15, 2021

Readme of opentelemetry-resources mentions SERVICE_RESOURCE enum (package @opentelemetry/resources) with resource attributes keys.
But actually, there is no such exported member.
These keys were moved to the ResourceAttributes in the @opentelemetry/semantic-conventions package.
Documentation should be updated accordingly.
@dyladan dyladan added document Documentation-related up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jun 16, 2021
@alisabzevari alisabzevari mentioned this issue Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
document Documentation-related up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(opentelemetry-resources): fix wrong sample code in readme alisabzevari/opentelemetry-js
2 participants
@dyladan @morigs