Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose counts for dropped attributes/events/links in ReadableSpan #2272

Closed
aabmass opened this issue Jun 10, 2021 · 7 comments · Fixed by #3576
Closed

Expose counts for dropped attributes/events/links in ReadableSpan #2272

aabmass opened this issue Jun 10, 2021 · 7 comments · Fixed by #3576
Assignees
Labels
good first issue Good for newcomers never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@aabmass
Copy link
Member

aabmass commented Jun 10, 2021

Regarding span limits, the spec says here:

Counts for attributes, events and links dropped due to collection limits MUST be available for exporters to report as described in the exporters specification.

However these counts are not exposed to exporters anywhere in ReadableSpan and should be made available

@dyladan dyladan added spec-v1 up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jun 16, 2021
@dyladan dyladan self-assigned this Jun 16, 2021
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Jun 16, 2021
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 10, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

This issue was closed because it has been stale for 14 days with no activity.

@github-actions github-actions bot closed this as completed Feb 7, 2022
@aabmass
Copy link
Member Author

aabmass commented Mar 21, 2022

@dyladan should this issue stay open? Looks like a missing MUST requirement

@dyladan dyladan reopened this Mar 21, 2022
@dyladan dyladan added never-stale good first issue Good for newcomers and removed stale labels Mar 21, 2022
@dyladan dyladan removed their assignment Mar 21, 2022
@dyladan dyladan added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 21, 2022
@mohitk05
Copy link
Contributor

Hello @aabmass @dyladan, is this still an open issue? I see that the ReadableSpan tagged in the description points to the deprecated tracing package. Though the new ReadableSpan interface in the sdk-trace-base package does not have the dropped count properties as well. If this still needs a contribution, I can pick it!

@dyladan
Copy link
Member

dyladan commented Jan 26, 2023

yes it still needs a contribution. thanks for volunteering!

@mohitk05
Copy link
Contributor

Okay, sure! Will start on this one.

@mohitk05
Copy link
Contributor

Hey @dyladan, have added a solution for this in #3576, let me know how it looks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants