Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OT Shim layer #2030

Closed
carlosalberto opened this issue Mar 19, 2021 · 6 comments
Closed

Update the OT Shim layer #2030

carlosalberto opened this issue Mar 19, 2021 · 6 comments
Labels
spec-feature This is a request to implement a new feature which is already specified by the OTel specification

Comments

@carlosalberto
Copy link

The OT Shim layer needs to be updated to include the latest changes as introduced by

open-telemetry/opentelemetry-specification#1101
open-telemetry/opentelemetry-specification#1563

@vmarchaud vmarchaud added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Mar 24, 2021
@vmarchaud
Copy link
Member

I'm not sure with this is required for GA cc @dyladan @obecny

@carlosalberto
Copy link
Author

@vmarchaud It's not required for 1.0, for sure (as it's still marked as Experimental).

@vreynolds
Copy link
Contributor

vreynolds commented Apr 29, 2021

Chunking up the updates:

  • add shim constructor with custom propagators [done]
  • spanShim.setTag updates [done]
  • spanShim.log updates [done]
  • span context immutability and managing association with span

I can work on the setTag updates next, will not claiming anything else at the moment :)

@vreynolds
Copy link
Contributor

@carlosalberto do you think the Span/SpanContext Shim section applies to OTEL-JS? I'm trying to wrap my head around it, and it seems out of scope because:

  • the requirement is stemming from multithreading concerns (not super familiar with evolving Node APIs, but I don't think that applies)
  • OpenTracing-JS never implemented Baggage inside SpanContext
  • OpenTracing-JS never implemented ScopeManger

WDYT?

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Aug 15, 2022
@pichlermarc pichlermarc added needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation spec-feature This is a request to implement a new feature which is already specified by the OTel specification and removed up-for-grabs Good for taking. Extra help will be provided by maintainers stale needs:refinement This issue needs to be refined/broken apart into sub-issues before implementation labels Oct 15, 2024
@pichlermarc
Copy link
Member

It looks like the last part was out of scope, everything else is done, so I'll close this issue. 🙂

If someone comes across this issue and determines that something else is missing, please open a new one so we don't overlook the comment here on this closed issue. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-feature This is a request to implement a new feature which is already specified by the OTel specification
Projects
None yet
Development

No branches or pull requests

4 participants