Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traceparent in meta tag not used #1916

Closed
drecaise opened this issue Feb 8, 2021 · 4 comments
Closed

traceparent in meta tag not used #1916

drecaise opened this issue Feb 8, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@drecaise
Copy link

drecaise commented Feb 8, 2021

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

v0.16.0 (with document-load v0.13.0) and v0.14.0
Open

What version of Node are you using?

v14.15.4

Please provide the code you used to setup the OpenTelemetry SDK

opentelemetry-js/examples/tracer-web/examples/document-load

What did you do?

For the v0.14.0 test:

  1. Clone repository
  2. Navigate to opentelementry-js/examples/tracer-web
  3. git checkout v0.14.0
  4. Execute npm install
  5. Execute npm start

I also tried checking out v0.16.0 and manually changing the document-load plugin to v0.13.0 in the package.json (Which gave the same result)

If possible, provide a recipe for reproducing the error.
Open up Chrome (In my case Chrome 88.0.4324.146 ) and navigate to: http://localhost:8090/document-load/

What did you expect to see?

I expected a trace for the load of the page with the same traceid as given in the meta tag of the index.html example:
ab42124a3c573678d4d8b21ba52df3bf

What did you see instead?

Only other traceids

Additional context

If I understand the explanation under: "Optional: Send a trace parent from your server" in this readme: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/v0.13.0/plugins/web/opentelemetry-plugin-document-load/README.md correctly I should be able to create a single trace with server and browser part combined. For this, I assume, the generated trace from the browser should use the traceid from the traceparent meta tag.

Add any other context about the problem here.

@drecaise drecaise added the bug Something isn't working label Feb 8, 2021
@obecny
Copy link
Member

obecny commented Feb 9, 2021

v0.16 is not compatible with contrib v0.13

@dyladan
Copy link
Member

dyladan commented Feb 9, 2021

v0.16 is not compatible with contrib v0.13

I'm working on an update to contrib right now

@obecny
Copy link
Member

obecny commented Feb 9, 2021

adding readme info -> #1920

@drecaise
Copy link
Author

Confirmed, I've successfully tested this:
Clone repository
Navigate to opentelementry-js/examples/tracer-web
git checkout v0.14.0
Edit package.json: Change plugin-document-load and plugin-user-interaction on lines 44-45 to use version "^0.13.0" instead of "^0.12.0"
Execute npm install
Execute npm start
Open up Chrome and navigate to: http://localhost:8090/document-load/ with the console open
Observed traceId is the same as in html meta tag
image

Thanks for quick clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants