You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This only affects the JavaScript OpenTelemetry library
This may affect other libraries, but I would like to get opinions here first
To better support / reduce code size can we change all of the enum values to be const enum, unless there is an absolute need for reverse lookups at runtime from the enum "name" to it's value. And as part of the API no actual object results (like interfaces) in the final code.
In most cases this should be a non-breaking change, except for any reverse lookups. This should be done before GA to avoid anyone taking dependencies on the full name and creating their own reverse lookups based on the default const object created by TypeScript.
eg
(Would need to add explicit values to avoid accidental breaks from insertions in the future)
To better support / reduce code size can we change all of the enum values to be const enum, unless there is an absolute need for reverse lookups at runtime from the enum "name" to it's value. And as part of the API no actual object results (like interfaces) in the final code.
In most cases this should be a non-breaking change, except for any reverse lookups. This should be done before GA to avoid anyone taking dependencies on the full name and creating their own reverse lookups based on the default const object created by TypeScript.
eg
(Would need to add explicit values to avoid accidental breaks from insertions in the future)
Usage becomes
The text was updated successfully, but these errors were encountered: