Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMapPropagator Getter.keys #1486

Closed
dyladan opened this issue Sep 2, 2020 · 0 comments · Fixed by #1576
Closed

TextMapPropagator Getter.keys #1486

dyladan opened this issue Sep 2, 2020 · 0 comments · Fixed by #1576
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Sep 2, 2020

Our current getter and setter arguments are just functions. They should be changed to be interfaces, and the getter should include a keys function. Changing them both to be interfaces now will make it easier to add additional required operations in the future.

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/context/api-propagators.md#keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant