Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stack context manager out of web #1386

Open
dyladan opened this issue Aug 4, 2020 · 2 comments
Open

Move stack context manager out of web #1386

dyladan opened this issue Aug 4, 2020 · 2 comments
Labels
enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Aug 4, 2020

As there is nothing web-specific about the stack context manager, and it may be useful in testing scenarios like #1344, we should consider moving the stack context manager out of web and into some place like core or into its own module.

@dyladan dyladan added the Discussion Issue or PR that needs/is extended discussion. label Aug 4, 2020
@anpatellll
Copy link

I support this motion

@vmarchaud vmarchaud added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers and removed Discussion Issue or PR that needs/is extended discussion. labels Nov 8, 2021
@olamideTiana
Copy link

@dyladan May I take a look at this? I will suggest to refactor the code to separate the concerns of the web framework from the context management logic to identify what parts of the stack context manager depend on the web framework and developing a new context manager that handles the stack logic independently of the web framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Development

No branches or pull requests

4 participants