Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absoluteness of instrument should not be configurable through options. #1241

Closed
1 of 2 tasks
lykkin opened this issue Jun 24, 2020 · 1 comment · Fixed by #1373
Closed
1 of 2 tasks

Absoluteness of instrument should not be configurable through options. #1241

lykkin opened this issue Jun 24, 2020 · 1 comment · Fixed by #1373

Comments

@lykkin
Copy link
Contributor

lykkin commented Jun 24, 2020

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

The properties of monotonicity and absoluteness are encoded in the instrument itself, rather than passed in as a descriptor by the user. Currently, instruments allow for absoluteness to be configured by the user upon instantiation.
@lykkin lykkin mentioned this issue Jun 24, 2020
Merged
@michaelgoin
Copy link
Contributor

It appears this is currently only done through the ValueRecorder? As such, will likely naturally take care of this at the same time as allowing negatives for ValueRecorder.

@michaelgoin michaelgoin mentioned this issue Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updates ValueRecorder to allow negative values michaelgoin/opentelemetry-js
2 participants
@lykkin @michaelgoin