You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am fine with this sort of breaking change as it is entirely contained within the SDK. We need to pass resource so I don't see a strong reason not to adopt this, we will just need to bump the minor version.
I think the spec issue and the proposal above both make sense. We should discuss those further at the Spec SIG. For now, we should go with what is specified in the SDK Resource spec
It says:
Analogous to distributed tracing, when used with metrics, a resource can be associated with a MeterProvider. When associated with a MeterProvider, all Metrics produced by any Meter from the provider will be associated with this Resource.
Is your feature request related to a problem? Please describe.
MetricExporter can not get access to Metric's resource in the current API.
Describe the solution you'd like
Add a parameter for resources like go's implementation https://github.com/open-telemetry/opentelemetry-go/blob/master/exporters/metric/prometheus/prometheus.go#L171
However, altering the order of the parameters will be a breaking change.
The text was updated successfully, but these errors were encountered: