Skip to content

Commit f9f89b8

Browse files
committed
fix: missing .fields() method in jaeger propagator (#268)
1 parent f6c9ef7 commit f9f89b8

File tree

2 files changed

+17
-0
lines changed

2 files changed

+17
-0
lines changed

packages/opentelemetry-propagator-jaeger/src/JaegerHttpTracePropagator.ts

+4
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,10 @@ export class JaegerHttpTracePropagator implements TextMapPropagator {
8080

8181
return setExtractedSpanContext(context, spanContext);
8282
}
83+
84+
fields(): string[] {
85+
return [this._jaegerTraceHeader];
86+
}
8387
}
8488

8589
/**

packages/opentelemetry-propagator-jaeger/test/JaegerHttpTracePropagator.test.ts

+13
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,19 @@ describe('JaegerHttpTracePropagator', () => {
172172
});
173173
});
174174

175+
describe('.fields()', () => {
176+
it('returns the default header if not customized', () => {
177+
assert.deepStrictEqual(jaegerHttpTracePropagator.fields(), [
178+
'uber-trace-id',
179+
]);
180+
});
181+
it('returns the customized header if customized', () => {
182+
assert.deepStrictEqual(customJaegerHttpTracePropagator.fields(), [
183+
customHeader,
184+
]);
185+
});
186+
});
187+
175188
it('should fail gracefully on bad responses from getter', () => {
176189
const ctx1 = jaegerHttpTracePropagator.extract(
177190
ROOT_CONTEXT,

0 commit comments

Comments
 (0)