From e2b061a09c5829a59e36be1a43d402e928bc6436 Mon Sep 17 00:00:00 2001 From: Johannes Huster <66320475+JohannesHuster@users.noreply.github.com> Date: Mon, 27 May 2024 18:51:45 +0200 Subject: [PATCH] refactor(core): Use exported strings for semconv --- .../src/platform/browser/sdk-info.ts | 16 +++++++++------- .../src/platform/node/sdk-info.ts | 16 +++++++++------- 2 files changed, 18 insertions(+), 14 deletions(-) diff --git a/packages/opentelemetry-core/src/platform/browser/sdk-info.ts b/packages/opentelemetry-core/src/platform/browser/sdk-info.ts index b804cd3c852..7d1460770dd 100644 --- a/packages/opentelemetry-core/src/platform/browser/sdk-info.ts +++ b/packages/opentelemetry-core/src/platform/browser/sdk-info.ts @@ -16,15 +16,17 @@ import { VERSION } from '../../version'; import { - TelemetrySdkLanguageValues, - SemanticResourceAttributes, + SEMRESATTRS_TELEMETRY_SDK_NAME, + SEMRESATTRS_PROCESS_RUNTIME_NAME, + SEMRESATTRS_TELEMETRY_SDK_LANGUAGE, + TELEMETRYSDKLANGUAGEVALUES_WEBJS, + SEMRESATTRS_TELEMETRY_SDK_VERSION, } from '@opentelemetry/semantic-conventions'; /** Constants describing the SDK in use */ export const SDK_INFO = { - [SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry', - [SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'browser', - [SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]: - TelemetrySdkLanguageValues.WEBJS, - [SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION, + [SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry', + [SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'browser', + [SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_WEBJS, + [SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION, }; diff --git a/packages/opentelemetry-core/src/platform/node/sdk-info.ts b/packages/opentelemetry-core/src/platform/node/sdk-info.ts index 6c7c4c5f02b..4018c23ff25 100644 --- a/packages/opentelemetry-core/src/platform/node/sdk-info.ts +++ b/packages/opentelemetry-core/src/platform/node/sdk-info.ts @@ -16,15 +16,17 @@ import { VERSION } from '../../version'; import { - TelemetrySdkLanguageValues, - SemanticResourceAttributes, + SEMRESATTRS_TELEMETRY_SDK_NAME, + SEMRESATTRS_PROCESS_RUNTIME_NAME, + SEMRESATTRS_TELEMETRY_SDK_LANGUAGE, + TELEMETRYSDKLANGUAGEVALUES_NODEJS, + SEMRESATTRS_TELEMETRY_SDK_VERSION, } from '@opentelemetry/semantic-conventions'; /** Constants describing the SDK in use */ export const SDK_INFO = { - [SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry', - [SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'node', - [SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]: - TelemetrySdkLanguageValues.NODEJS, - [SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION, + [SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry', + [SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'node', + [SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_NODEJS, + [SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION, };