chore: remove config from BasicTracerProvider#getTracer (#1908)

Flarna · dyladan · web-flow · commit dc384956b3c7 · 2021-02-08T15:04:56.000-05:00
Co-authored-by: Daniel Dyla &lt;dyladan@users.noreply.github.com&gt;
diff --git a/packages/opentelemetry-tracing/src/BasicTracerProvider.ts b/packages/opentelemetry-tracing/src/BasicTracerProvider.ts
@@ -52,13 +52,10 @@ export class BasicTracerProvider implements api.TracerProvider {
     });
   }
 
-  getTracer(name: string, version?: string, config?: TracerConfig): Tracer {
+  getTracer(name: string, version?: string): Tracer {
     const key = `${name}@${version || ''}`;
     if (!this._tracers.has(key)) {
-      this._tracers.set(
-        key,
-        new Tracer({ name, version }, config || this._config, this)
-      );
+      this._tracers.set(key, new Tracer({ name, version }, this._config, this));
     }
 
     return this._tracers.get(key)!;

Original file line number	Diff line number	Diff line change
`@@ -52,13 +52,10 @@ export class BasicTracerProvider implements api.TracerProvider {`
`52`	`52`	`});`
`53`	`53`	`}`
`54`	`54`
`55`		`- getTracer(name: string, version?: string, config?: TracerConfig): Tracer {`
	`55`	`+ getTracer(name: string, version?: string): Tracer {`
`56`	`56`	const key = `${name}@${version \|\| ''}`;
`57`	`57`	`if (!this._tracers.has(key)) {`
`58`		`- this._tracers.set(`
`59`		`- key,`
`60`		`- new Tracer({ name, version }, config \|\| this._config, this)`
`61`		`- );`
	`58`	`+ this._tracers.set(key, new Tracer({ name, version }, this._config, this));`
`62`	`59`	`}`
`63`	`60`
`64`	`61`	`return this._tracers.get(key)!;`