Skip to content

Commit bb0e436

Browse files
committed
chore: reword test descriptions
1 parent a7cea78 commit bb0e436

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ describe('CollectorExporterNodeBase', () => {
8888
// Mock that all requests finish sending
8989
exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess());
9090

91-
// All finished promises should be dropped off
91+
// All finished promises should be popped off
9292
await promisesAllDone;
9393
assert.strictEqual(exporter['_sendingPromises'].length, 0);
9494
});
9595

96-
it('should drop export requests when already sending concurrencyLimit', async () => {
96+
it('should drop new export requests when already sending at concurrencyLimit', async () => {
9797
const spans = [Object.assign({}, mockedReadableSpan)];
9898
const numToExport = concurrencyLimit + 5;
9999

@@ -106,12 +106,12 @@ describe('CollectorExporterNodeBase', () => {
106106
// Mock that all requests finish sending
107107
exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess());
108108

109-
// All finished promises should be dropped off
109+
// All finished promises should be popped off
110110
await promisesAllDone;
111111
assert.strictEqual(exporter['_sendingPromises'].length, 0);
112112
});
113113

114-
it('should drop export requests even if they failed', async () => {
114+
it('should pop export request promises even if they failed', async () => {
115115
const spans = [Object.assign({}, mockedReadableSpan)];
116116

117117
exporter.export(spans, () => {});
@@ -122,12 +122,12 @@ describe('CollectorExporterNodeBase', () => {
122122
onError(new Error('Failed to send!!'))
123123
);
124124

125-
// All finished promises should be dropped off
125+
// All finished promises should be popped off
126126
await promisesAllDone;
127127
assert.strictEqual(exporter['_sendingPromises'].length, 0);
128128
});
129129

130-
it('should drop export requests even if success callback throws error', async () => {
130+
it('should pop export request promises even if success callback throws error', async () => {
131131
const spans = [Object.assign({}, mockedReadableSpan)];
132132

133133
exporter['_sendPromise'](
@@ -145,7 +145,7 @@ describe('CollectorExporterNodeBase', () => {
145145
onSuccess();
146146
});
147147

148-
// All finished promises should be dropped off
148+
// All finished promises should be popped off
149149
await promisesAllDone;
150150
assert.strictEqual(exporter['_sendingPromises'].length, 0);
151151
});

0 commit comments

Comments
 (0)