@@ -88,12 +88,12 @@ describe('CollectorExporterNodeBase', () => {
88
88
// Mock that all requests finish sending
89
89
exporter . sendCallbacks . forEach ( ( { onSuccess } ) => onSuccess ( ) ) ;
90
90
91
- // All finished promises should be dropped off
91
+ // All finished promises should be popped off
92
92
await promisesAllDone ;
93
93
assert . strictEqual ( exporter [ '_sendingPromises' ] . length , 0 ) ;
94
94
} ) ;
95
95
96
- it ( 'should drop export requests when already sending concurrencyLimit' , async ( ) => {
96
+ it ( 'should drop new export requests when already sending at concurrencyLimit' , async ( ) => {
97
97
const spans = [ Object . assign ( { } , mockedReadableSpan ) ] ;
98
98
const numToExport = concurrencyLimit + 5 ;
99
99
@@ -106,12 +106,12 @@ describe('CollectorExporterNodeBase', () => {
106
106
// Mock that all requests finish sending
107
107
exporter . sendCallbacks . forEach ( ( { onSuccess } ) => onSuccess ( ) ) ;
108
108
109
- // All finished promises should be dropped off
109
+ // All finished promises should be popped off
110
110
await promisesAllDone ;
111
111
assert . strictEqual ( exporter [ '_sendingPromises' ] . length , 0 ) ;
112
112
} ) ;
113
113
114
- it ( 'should drop export requests even if they failed' , async ( ) => {
114
+ it ( 'should pop export request promises even if they failed' , async ( ) => {
115
115
const spans = [ Object . assign ( { } , mockedReadableSpan ) ] ;
116
116
117
117
exporter . export ( spans , ( ) => { } ) ;
@@ -122,12 +122,12 @@ describe('CollectorExporterNodeBase', () => {
122
122
onError ( new Error ( 'Failed to send!!' ) )
123
123
) ;
124
124
125
- // All finished promises should be dropped off
125
+ // All finished promises should be popped off
126
126
await promisesAllDone ;
127
127
assert . strictEqual ( exporter [ '_sendingPromises' ] . length , 0 ) ;
128
128
} ) ;
129
129
130
- it ( 'should drop export requests even if success callback throws error' , async ( ) => {
130
+ it ( 'should pop export request promises even if success callback throws error' , async ( ) => {
131
131
const spans = [ Object . assign ( { } , mockedReadableSpan ) ] ;
132
132
133
133
exporter [ '_sendPromise' ] (
@@ -145,7 +145,7 @@ describe('CollectorExporterNodeBase', () => {
145
145
onSuccess ( ) ;
146
146
} ) ;
147
147
148
- // All finished promises should be dropped off
148
+ // All finished promises should be popped off
149
149
await promisesAllDone ;
150
150
assert . strictEqual ( exporter [ '_sendingPromises' ] . length , 0 ) ;
151
151
} ) ;
0 commit comments