Skip to content

Commit a58f510

Browse files
chore(sdk-trace-web): fix lint warnings (#2451)
Co-authored-by: Daniel Dyla <[email protected]>
1 parent 58bfe25 commit a58f510

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

packages/opentelemetry-sdk-trace-web/src/StackContextManager.ts

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export class StackContextManager implements ContextManager {
3636
* @param context
3737
* @param target Function to be executed within the context
3838
*/
39+
// eslint-disable-next-line @typescript-eslint/ban-types
3940
private _bindFunction<T extends Function>(
4041
context = ROOT_CONTEXT,
4142
target: T

packages/opentelemetry-sdk-trace-web/src/WebTracerProvider.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class WebTracerProvider extends BasicTracerProvider {
5555
*
5656
* @param config Configuration object for SDK registration
5757
*/
58-
override register(config: SDKRegistrationConfig = {}) {
58+
override register(config: SDKRegistrationConfig = {}): void {
5959
if (config.contextManager === undefined) {
6060
config.contextManager = new StackContextManager();
6161
}

packages/opentelemetry-sdk-trace-web/src/utils.ts

+11-11
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ import {
2929
import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
3030

3131
// Used to normalize relative URLs
32-
let a: HTMLAnchorElement | undefined;
32+
let urlNormalizingAnchor: HTMLAnchorElement | undefined;
3333
export function getUrlNormalizingAnchor(): HTMLAnchorElement {
34-
if (!a) {
35-
a = document.createElement('a');
34+
if (!urlNormalizingAnchor) {
35+
urlNormalizingAnchor = document.createElement('a');
3636
}
3737

38-
return a;
38+
return urlNormalizingAnchor;
3939
}
4040

4141
/**
@@ -108,7 +108,7 @@ export function addSpanNetworkEvents(
108108
* sort resources by startTime
109109
* @param filteredResources
110110
*/
111-
export function sortResources(filteredResources: PerformanceResourceTiming[]) {
111+
export function sortResources(filteredResources: PerformanceResourceTiming[]): PerformanceResourceTiming[] {
112112
return filteredResources.slice().sort((a, b) => {
113113
const valueA = a[PTN.FETCH_START];
114114
const valueB = b[PTN.FETCH_START];
@@ -284,9 +284,9 @@ function filterResourcesForSpan(
284284
* @param url
285285
*/
286286
export function parseUrl(url: string): HTMLAnchorElement {
287-
const a = document.createElement('a');
288-
a.href = url;
289-
return a;
287+
const element = document.createElement('a');
288+
element.href = url;
289+
return element;
290290
}
291291

292292
/**
@@ -295,8 +295,8 @@ export function parseUrl(url: string): HTMLAnchorElement {
295295
* @param optimised - when id attribute of element is present the xpath can be
296296
* simplified to contain id
297297
*/
298-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
299-
export function getElementXPath(target: any, optimised?: boolean) {
298+
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
299+
export function getElementXPath(target: any, optimised?: boolean): string {
300300
if (target.nodeType === Node.DOCUMENT_NODE) {
301301
return '/';
302302
}
@@ -380,7 +380,7 @@ function getNodeValue(target: HTMLElement, optimised?: boolean): string {
380380
export function shouldPropagateTraceHeaders(
381381
spanUrl: string,
382382
propagateTraceHeaderCorsUrls?: PropagateTraceHeaderCorsUrls
383-
) {
383+
): boolean {
384384
let propagateTraceHeaderUrls = propagateTraceHeaderCorsUrls || [];
385385
if (
386386
typeof propagateTraceHeaderUrls === 'string' ||

0 commit comments

Comments
 (0)