Skip to content

Commit 9a91434

Browse files
OlivierAlbertinimayurkale22
authored andcommitted
fix(plugin-dns): remove from default plugin list (#613)
closes #612 Signed-off-by: Olivier Albertini <[email protected]>
1 parent d32565a commit 9a91434

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

packages/opentelemetry-node/src/config.ts

-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export interface NodeTracerConfig extends BasicTracerConfig {
2828
/** List of all default supported plugins */
2929
export const DEFAULT_INSTRUMENTATION_PLUGINS: Plugins = {
3030
'mongodb-core': { enabled: true, path: '@opentelemetry/plugin-mongodb-core' },
31-
dns: { enabled: true, path: '@opentelemetry/plugin-dns' },
3231
grpc: { enabled: true, path: '@opentelemetry/plugin-grpc' },
3332
http: { enabled: true, path: '@opentelemetry/plugin-http' },
3433
https: { enabled: true, path: '@opentelemetry/plugin-https' },

packages/opentelemetry-plugin-dns/README.md

+17
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,23 @@ const tracer = new NodeTracer({
3232
});
3333
```
3434

35+
### Zipkin
36+
37+
If you use Zipkin, you must use `ignoreHostnames` in order to not trace those calls. If the server is local. You can set :
38+
39+
```
40+
const tracer = new NodeTracer({
41+
plugins: {
42+
dns: {
43+
enabled: true,
44+
// You may use a package name or absolute path to the file.
45+
path: '@opentelemetry/plugin-dns',
46+
ignoreHostnames: ['localhost']
47+
}
48+
}
49+
});
50+
```
51+
3552
### Dns Plugin Options
3653

3754
Dns plugin has currently one option. You can set the following:

0 commit comments

Comments
 (0)