Skip to content

Commit 65b2b79

Browse files
authored
Log name and ID on span end misuse (#3716)
* Log name and ID on span end misuse * Changelog * lint
1 parent 73da976 commit 65b2b79

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
1111

1212
### :rocket: (Enhancement)
1313

14+
* feat(tracing): log span name and IDs when span end is called multiple times [#3716](https://github.com/open-telemetry/opentelemetry-js/pull/3716)
15+
1416
### :bug: (Bug Fix)
1517

1618
* fix(instrumentation-http): fixed description for http.server.duration metric [#3710](https://github.com/open-telemetry/opentelemetry-js/pull/3710)

packages/opentelemetry-sdk-trace-base/src/Span.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,9 @@ export class Span implements APISpan, ReadableSpan {
216216

217217
end(endTime?: TimeInput): void {
218218
if (this._isSpanEnded()) {
219-
diag.error('You can only call end() on a span once.');
219+
diag.error(
220+
`${this.name} ${this._spanContext.traceId}-${this._spanContext.spanId} - You can only call end() on a span once.`
221+
);
220222
return;
221223
}
222224
this._ended = true;

0 commit comments

Comments
 (0)