Skip to content

Commit 5d78863

Browse files
obecnyobecny
authored
Merge branch 'main' into fix/core-window
2 parents 85c0366 + 9df2132 commit 5d78863

File tree

242 files changed

+2539
-2705
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

242 files changed

+2539
-2705
lines changed

‎.github/PULL_REQUEST_TEMPLATE.md

+23-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,29 @@ Before creating a pull request, please make sure:
1515

1616
## Which problem is this PR solving?
1717

18-
-
18+
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
19+
20+
Fixes # (issue)
1921

2022
## Short description of the changes
2123

22-
-
24+
## Type of change
25+
26+
Please delete options that are not relevant.
27+
28+
- [ ] Bug fix (non-breaking change which fixes an issue)
29+
- [ ] New feature (non-breaking change which adds functionality)
30+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
31+
- [ ] This change requires a documentation update
32+
33+
## How Has This Been Tested?
34+
35+
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
36+
37+
- [ ] Test A
38+
39+
## Checklist:
40+
41+
- [ ] Followed the style guidelines of this project
42+
- [ ] Unit tests have been added
43+
- [ ] Documentation has been updated

‎.github/workflows/unit-test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
with:
104104
path: |
105105
experimental/node_modules
106-
experimental/packages/*/node_modules
106+
experimental/*/*/node_modules
107107
key: node-tests-experimental-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('experimental/**/package.json') }}
108108

109109
- name: Bootstrap
@@ -143,7 +143,7 @@ jobs:
143143
with:
144144
path: |
145145
experimental/node_modules
146-
experimental/packages/*/node_modules
146+
experimental/*/*/node_modules
147147
key: browser-tests-experimental-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('**/package.json') }}
148148

149149
- name: Bootstrap

‎.github/workflows/w3c-integration-test.yml

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ jobs:
2222
package-lock.json
2323
packages/*/package-lock.json
2424
benchmark/*/package-lock.json
25-
backwards-compatability/*/package-lock.json
2625
metapackages/*/package-lock.json
2726
packages/*/package-lock.json
2827
integration-tests/*/package-lock.json

‎.gitmodules

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
[submodule "packages/opentelemetry-exporter-otlp-grpc/protos"]
2-
path = packages/opentelemetry-exporter-otlp-grpc/protos
1+
[submodule "experimental/packages/opentelemetry-exporter-otlp-proto/protos"]
2+
path = experimental/packages/opentelemetry-exporter-otlp-proto/protos
33
url = https://github.com/open-telemetry/opentelemetry-proto.git
4-
[submodule "packages/opentelemetry-exporter-otlp-proto/protos"]
5-
path = packages/opentelemetry-exporter-otlp-proto/protos
4+
[submodule "experimental/packages/opentelemetry-exporter-otlp-grpc/protos"]
5+
path = experimental/packages/opentelemetry-exporter-otlp-grpc/protos
66
url = https://github.com/open-telemetry/opentelemetry-proto.git

‎CHANGELOG.md

+92
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,96 @@ All notable changes to this project will be documented in this file.
44

55
## Unreleased
66

7+
## 1.0.0
8+
9+
No changes
10+
11+
## 0.26.0
12+
13+
### :boom: Breaking Change
14+
15+
* `opentelemetry-exporter-collector-grpc`, `opentelemetry-exporter-otlp-grpc`, `opentelemetry-exporter-otlp-http`, `opentelemetry-exporter-otlp-proto`
16+
* [#2476](https://github.com/open-telemetry/opentelemetry-js/pull/2476) chore!: rename collector exporters ([@dyladan](https://github.com/dyladan))
17+
* `opentelemetry-core`, `opentelemetry-instrumentation-grpc`, `opentelemetry-sdk-trace-base`, `opentelemetry-shim-opentracing`
18+
* [#2429](https://github.com/open-telemetry/opentelemetry-js/pull/2429) fix!: remove 'Http' from W3C propagator names ([@aabmass](https://github.com/aabmass))
19+
20+
### :rocket: (Enhancement)
21+
22+
* `opentelemetry-core`, `opentelemetry-sdk-trace-base`
23+
* [#2430](https://github.com/open-telemetry/opentelemetry-js/pull/2430) feat(opentelemetry-sdk-trace-base): implemented general limits of attributes ([@banothurameshnaik](https://github.com/banothurameshnaik))
24+
* [#2418](https://github.com/open-telemetry/opentelemetry-js/pull/2418) feat(opentelemetry-sdk-trace-base): implemented option to limit length of values of attributes ([@banothurameshnaik](https://github.com/banothurameshnaik))
25+
* `opentelemetry-instrumentation`
26+
* [#2450](https://github.com/open-telemetry/opentelemetry-js/pull/2450) fix: handle missing package.json file when checking for version ([@nozik](https://github.com/nozik))
27+
* `opentelemetry-semantic-conventions`
28+
* [#2456](https://github.com/open-telemetry/opentelemetry-js/pull/2456) feat: upgrade semantic conventions to the latest 1.6.1 version ([@weyert](https://github.com/weyert))
29+
* `opentelemetry-exporter-collector-proto`, `opentelemetry-exporter-collector`
30+
* [#2438](https://github.com/open-telemetry/opentelemetry-js/pull/2438) feat: OTEL_EXPORTER_OTLP_ENDPOINT append version and signal ([@longility](https://github.com/longility))
31+
32+
### :bug: (Bug Fix)
33+
34+
* Other
35+
* [#2494](https://github.com/open-telemetry/opentelemetry-js/pull/2494) fix: remove setting http.route in http span attributes ([@mustafain117](https://github.com/mustafain117))
36+
* `opentelemetry-instrumentation-fetch`
37+
* [#2426](https://github.com/open-telemetry/opentelemetry-js/pull/2426) fix(opentelemetry-instrumentation-fetch): fixed override of headers ([@philipszalla](https://github.com/philipszalla))
38+
* `opentelemetry-sdk-trace-base`
39+
* [#2434](https://github.com/open-telemetry/opentelemetry-js/pull/2434) fix: ReferenceError when OTEL_TRACES_SAMPLER used without OTEL_TRACES_SAMPLER_ARG ([@hermanbanken](https://github.com/hermanbanken))
40+
41+
### :books: (Refine Doc)
42+
43+
* [#2478](https://github.com/open-telemetry/opentelemetry-js/pull/2478) Update links to packages moved to experimental ([@jessitron](https://github.com/jessitron))
44+
* [#2463](https://github.com/open-telemetry/opentelemetry-js/pull/2463) docs(README): Fix links in README.md ([@JamesJHPark](https://github.com/JamesJHPark))
45+
* [#2437](https://github.com/open-telemetry/opentelemetry-js/pull/2437) docs(examples): updated examples readme links ([@banothurameshnaik](https://github.com/banothurameshnaik))
46+
* [#2421](https://github.com/open-telemetry/opentelemetry-js/pull/2421) docs(website): support GH page links to canonical src ([@chalin](https://github.com/chalin))
47+
* [#2408](https://github.com/open-telemetry/opentelemetry-js/pull/2408) docs: make link to exporters filter only exporters ([@Rauno56](https://github.com/Rauno56))
48+
* [#2297](https://github.com/open-telemetry/opentelemetry-js/pull/2297) eslint configuration for getting-started examples ([@alisabzevari](https://github.com/alisabzevari))
49+
50+
### :house: (Internal)
51+
52+
* `opentelemetry-exporter-otlp-http`
53+
* [#2490](https://github.com/open-telemetry/opentelemetry-js/pull/2490) chore: mark otlp exporters experimental ([@dyladan](https://github.com/dyladan))
54+
* [#2491](https://github.com/open-telemetry/opentelemetry-js/pull/2491) fix: remove usage of serviceName property in tests for otel collector ([@mustafain117](https://github.com/mustafain117))
55+
* `opentelemetry-sdk-node`
56+
* [#2473](https://github.com/open-telemetry/opentelemetry-js/pull/2473) chore: move sdk-node to experimental ([@dyladan](https://github.com/dyladan))
57+
* [#2453](https://github.com/open-telemetry/opentelemetry-js/pull/2453) chore(sdk-node): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
58+
* Other
59+
* [#2469](https://github.com/open-telemetry/opentelemetry-js/pull/2469) Drop website_docs folder ([@chalin](https://github.com/chalin))
60+
* [#2474](https://github.com/open-telemetry/opentelemetry-js/pull/2474) chore: move missed test file to its package ([@dyladan](https://github.com/dyladan))
61+
* [#2435](https://github.com/open-telemetry/opentelemetry-js/pull/2435) chore: simplify unit test cache ([@dyladan](https://github.com/dyladan))
62+
* `opentelemetry-context-zone`, `opentelemetry-core`, `opentelemetry-exporter-collector-grpc`, `opentelemetry-exporter-collector-proto`, `opentelemetry-exporter-collector`, `opentelemetry-exporter-prometheus`, `opentelemetry-exporter-zipkin`, `opentelemetry-instrumentation-fetch`, `opentelemetry-instrumentation-grpc`, `opentelemetry-instrumentation-http`, `opentelemetry-instrumentation-xml-http-request`, `opentelemetry-propagator-b3`, `opentelemetry-propagator-jaeger`, `opentelemetry-resources`, `opentelemetry-sdk-metrics-base`, `opentelemetry-sdk-node`, `opentelemetry-sdk-trace-base`, `opentelemetry-sdk-trace-web`
63+
* [#2462](https://github.com/open-telemetry/opentelemetry-js/pull/2462) chore: split stable and experimental packages into groups using directories ([@dyladan](https://github.com/dyladan))
64+
* `opentelemetry-instrumentation-http`
65+
* [#2126](https://github.com/open-telemetry/opentelemetry-js/pull/2126) feat(instrumentation-http): add diag debug on http request events ([@Asafb26](https://github.com/Asafb26))
66+
* [#2455](https://github.com/open-telemetry/opentelemetry-js/pull/2455) chore(instrumentation-http): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
67+
* `opentelemetry-instrumentation-fetch`
68+
* [#2454](https://github.com/open-telemetry/opentelemetry-js/pull/2454) chore(instrumentation-fetch): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
69+
* `opentelemetry-exporter-collector`
70+
* [#2452](https://github.com/open-telemetry/opentelemetry-js/pull/2452) chore(exporter-collector): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
71+
* `opentelemetry-sdk-trace-base`, `opentelemetry-sdk-trace-node`
72+
* [#2446](https://github.com/open-telemetry/opentelemetry-js/pull/2446) chore(sdk-trace): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
73+
* `opentelemetry-exporter-prometheus`, `opentelemetry-exporter-zipkin`, `opentelemetry-shim-opentracing`
74+
* [#2447](https://github.com/open-telemetry/opentelemetry-js/pull/2447) chore(exporter): fix lint warnings ([@alisabzevari](https://github.com/alisabzevari))
75+
76+
### Committers: 18
77+
78+
* Aaron Abbott ([@aabmass](https://github.com/aabmass))
79+
* Ali Sabzevari ([@alisabzevari](https://github.com/alisabzevari))
80+
* Asaf Ben Aharon ([@Asafb26](https://github.com/Asafb26))
81+
* Banothu Ramesh Naik ([@banothurameshnaik](https://github.com/banothurameshnaik))
82+
* Daniel Dyla ([@dyladan](https://github.com/dyladan))
83+
* Gerhard Stöbich ([@Flarna](https://github.com/Flarna))
84+
* Herman ([@hermanbanken](https://github.com/hermanbanken))
85+
* James ([@JamesJHPark](https://github.com/JamesJHPark))
86+
* Jessica Kerr ([@jessitron](https://github.com/jessitron))
87+
* Long Mai ([@longility](https://github.com/longility))
88+
* Mustafain Ali Khan ([@mustafain117](https://github.com/mustafain117))
89+
* Patrice Chalin ([@chalin](https://github.com/chalin))
90+
* Philip Szalla ([@philipszalla](https://github.com/philipszalla))
91+
* Ran Nozik ([@nozik](https://github.com/nozik))
92+
* Rauno Viskus ([@Rauno56](https://github.com/Rauno56))
93+
* Siim Kallas ([@seemk](https://github.com/seemk))
94+
* Weyert de Boer ([@weyert](https://github.com/weyert))
95+
* legendecas ([@legendecas](https://github.com/legendecas))
96+
797
## 0.25.0
898

999
### :boom: Breaking Change
@@ -20,6 +110,8 @@ All notable changes to this project will be documented in this file.
20110

21111
### :bug: (Bug Fix)
22112

113+
* `opentelemetry-instrumentation-grpc`, `opentelemetry-instrumentation-http`, `opentelemetry-instrumentation-jaeger`, `opentelemetry-exporter-zipkin`, `opentelemetry-sdk-trace-base`
114+
* [#2499](https://github.com/open-telemetry/opentelemetry-js/pull/2499) fix: 2389- replaced logger unformatted strings with template literals ([@PaurushGarg](https://github.com/PaurushGarg))
23115
* `opentelemetry-instrumentation-fetch`
24116
* [#2411](https://github.com/open-telemetry/opentelemetry-js/pull/2411) fix(instrumentation-fetch): `fetch(string, Request)` silently drops request body ([@t2t2](https://github.com/t2t2))
25117
* `opentelemetry-sdk-trace-base`

‎README.md

+44-19
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
---
33
<p align="center">
44
<strong>
5-
<a href="https://github.com/open-telemetry/opentelemetry-js/blob/main/getting-started/README.md">Getting Started</a>
5+
<a href="https://opentelemetry.io/docs/js/getting_started/">Getting Started</a>
66
&nbsp;&nbsp;&bull;&nbsp;&nbsp;
77
<a href="https://open-telemetry.github.io/opentelemetry-js-api">API Reference</a>
88
&nbsp;&nbsp;&bull;&nbsp;&nbsp;
@@ -47,23 +47,25 @@ This is the JavaScript version of [OpenTelemetry](https://opentelemetry.io/), a
4747

4848
## Compatibility Matrix
4949

50-
| API Version | Core version | Contrib Version |
51-
| ----------- |--------------|-------------------------|
52-
| 1.0.x | 0.25.x | ------ |
53-
| 1.0.x | 0.24.x | 0.24.x |
54-
| 1.0.x | 0.23.x | 0.23.x |
55-
| 1.0.x | 0.22.x | 0.22.x |
56-
| 0.21.x | 0.21.x | 0.21.x |
57-
| 0.20.x | 0.20.x | 0.20.x |
58-
| v1.0.0-rc.3 | 0.19.x | 0.16.x |
59-
| 0.18.x | 0.18.x | 0.14.x |
60-
| | 0.17.x | ------ |
61-
| | 0.16.x | ------ |
62-
| | 0.15.x | 0.13.x |
63-
| | 0.14.x | 0.12.x |
64-
| | 0.13.x | ------ |
65-
| | 0.12.x | 0.11.x |
66-
| | 0.11.x | 0.10.x |
50+
| API Version | Core version | Experimental Packages | Contrib Version |
51+
| ----------- |--------------| --------------------- |-------------------------|
52+
| 1.0.x | 1.x | 0.26.x | ------ |
53+
| 1.0.x | 0.26.x | ----- | ------ |
54+
| 1.0.x | 0.25.x | ----- | ------ |
55+
| 1.0.x | 0.24.x | ----- | 0.24.x |
56+
| 1.0.x | 0.23.x | ----- | 0.23.x |
57+
| 1.0.x | 0.22.x | ----- | 0.22.x |
58+
| 0.21.x | 0.21.x | ----- | 0.21.x |
59+
| 0.20.x | 0.20.x | ----- | 0.20.x |
60+
| v1.0.0-rc.3 | 0.19.x | ----- | 0.16.x |
61+
| 0.18.x | 0.18.x | ----- | 0.14.x |
62+
| | 0.17.x | ----- | ------ |
63+
| | 0.16.x | ----- | ------ |
64+
| | 0.15.x | ----- | 0.13.x |
65+
| | 0.14.x | ----- | 0.12.x |
66+
| | 0.13.x | ----- | ------ |
67+
| | 0.12.x | ----- | 0.11.x |
68+
| | 0.11.x | ----- | 0.10.x |
6769

6870
## Versioning
6971

@@ -129,7 +131,7 @@ process.on('SIGTERM', () => {
129131
node -r ./tracing.js app.js
130132
```
131133

132-
The above example will emit auto-instrumented telemetry about your Node.js application to the console. For a more in-depth example, see the [Getting Started Guide](https://github.com/open-telemetry/opentelemetry-js/blob/main/getting-started/README.md). For more information about automatic instrumentation see [@opentelemetry/sdk-trace-node][otel-node], which provides auto-instrumentation for Node.js applications. If the automatic instrumentation does not suit your needs, or you would like to create manual traces, see [@opentelemetry/sdk-trace-base][otel-tracing]
134+
The above example will emit auto-instrumented telemetry about your Node.js application to the console. For a more in-depth example, see the [Getting Started Guide](https://opentelemetry.io/docs/js/getting_started/). For more information about automatic instrumentation see [@opentelemetry/sdk-trace-node][otel-node], which provides auto-instrumentation for Node.js applications. If the automatic instrumentation does not suit your needs, or you would like to create manual traces, see [@opentelemetry/sdk-trace-base][otel-tracing]
133135

134136
### Library Author
135137

@@ -284,6 +286,29 @@ To request automatic tracing support for a module not on this list, please [file
284286

285287
## Upgrade guidelines
286288

289+
### 0.26.x to 0.27.x
290+
291+
Metric types are renamed:
292+
293+
- `@openetelemetry/api-metrics`
294+
- `Meter`
295+
- `createValueRecorder` => `createHistogram`
296+
- `createValueObserver` => `createObservableGauge`
297+
- `createSumObserver` => `createObservableCounter`
298+
- `createUpDownSumObserver` => `createObservableUpDownCounter`
299+
- `ValueRecorder` => `Histogram`
300+
- `ValueObserver` => `ObservableGauge`
301+
- `SumObserver` => `ObservableCounter`
302+
- `UpDownSumObserver` => `ObservableUpDownCounter`
303+
- `ObserverResult` => `ObservableResult`
304+
- `Observation.observer` => `Observation.observable`
305+
- `@opentelemetry/sdk-metrics-base`
306+
- `MetricKind`
307+
- `VALUE_RECORDER` => `HISTOGRAM`
308+
- `SUM_OBSERVER` => `OBSERVABLE_COUNTER`
309+
- `UP_DOWN_SUM_OBSERVER` => `OBSERVABLE_UP_DOWN_COUNTER`
310+
- `VALUE_OBSERVER` => `OBSERVABLE_GAUGE`
311+
287312
### 0.25.x to 1.x.y
288313

289314
Collector exporter packages and types are renamed:

‎doc/processor-api.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ const meter = new MeterProvider({
138138
interval: 1000,
139139
}).getMeter('example-custom-processor');
140140

141-
const requestsLatency = meter.createValueRecorder('requests', {
141+
const requestsLatency = meter.createHistogram('requests', {
142142
monotonic: true,
143143
description: 'Average latency'
144144
});

‎examples/metrics/metrics/observer.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -21,29 +21,29 @@ const exporter = new PrometheusExporter(
2121
const meter = new MeterProvider({
2222
exporter,
2323
interval: 2000,
24-
}).getMeter('example-observer');
24+
}).getMeter('example-meter');
2525

26-
meter.createValueObserver('cpu_core_usage', {
27-
description: 'Example of a sync value observer with callback',
28-
}, async (observerResult) => { // this callback is called once per each interval
26+
meter.createObservableGauge('cpu_core_usage', {
27+
description: 'Example of a sync observable gauge with callback',
28+
}, async (observableResult) => { // this callback is called once per each interval
2929
await new Promise((resolve) => {
3030
setTimeout(()=> {resolve()}, 50);
3131
});
32-
observerResult.observe(getRandomValue(), { core: '1' });
33-
observerResult.observe(getRandomValue(), { core: '2' });
32+
observableResult.observe(getRandomValue(), { core: '1' });
33+
observableResult.observe(getRandomValue(), { core: '2' });
3434
});
3535

3636
// no callback as they will be updated in batch observer
37-
const tempMetric = meter.createValueObserver('cpu_temp_per_app', {
38-
description: 'Example of sync value observer used with async batch observer',
37+
const tempMetric = meter.createObservableGauge('cpu_temp_per_app', {
38+
description: 'Example of sync observable gauge used with async batch observer',
3939
});
4040

4141
// no callback as they will be updated in batch observer
42-
const cpuUsageMetric = meter.createValueObserver('cpu_usage_per_app', {
43-
description: 'Example of sync value observer used with async batch observer',
42+
const cpuUsageMetric = meter.createObservableGauge('cpu_usage_per_app', {
43+
description: 'Example of sync observable gauge used with async batch observer',
4444
});
4545

46-
meter.createBatchObserver((observerBatchResult) => {
46+
meter.createBatchObserver((batchObserverResult) => {
4747
Promise.all([
4848
someAsyncMetrics(),
4949
// simulate waiting
@@ -52,11 +52,11 @@ meter.createBatchObserver((observerBatchResult) => {
5252
}),
5353
]).then(([apps, waiting]) => {
5454
apps.forEach(app => {
55-
observerBatchResult.observe({ app: app.name, core: '1' }, [
55+
batchObserverResult.observe({ app: app.name, core: '1' }, [
5656
tempMetric.observation(app.core1.temp),
5757
cpuUsageMetric.observation(app.core1.usage),
5858
]);
59-
observerBatchResult.observe({ app: app.name, core: '2' }, [
59+
batchObserverResult.observe({ app: app.name, core: '2' }, [
6060
tempMetric.observation(app.core2.temp),
6161
cpuUsageMetric.observation(app.core2.usage),
6262
]);

0 commit comments

Comments
 (0)