Skip to content

Commit 4a54c84

Browse files
committed
refactor: merge opentelemetry-base to opentelemetry-core
They act a very similar role in the SDK.
1 parent e4e71b8 commit 4a54c84

File tree

27 files changed

+88
-29
lines changed

27 files changed

+88
-29
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
/*!
2+
* Copyright 2019, OpenTelemetry Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
export enum ExportResult {
18+
SUCCESS,
19+
FAILED_NOT_RETRYABLE,
20+
FAILED_RETRYABLE,
21+
}

packages/opentelemetry-core/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export * from './common/ConsoleLogger';
1818
export * from './common/NoopLogger';
1919
export * from './common/time';
2020
export * from './common/types';
21+
export * from './ExportResult';
2122
export * from './version';
2223
export * from './context/context';
2324
export * from './context/propagation/B3Propagator';
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/**
2+
* Copyright 2020, OpenTelemetry Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
import { VERSION } from '../../version';
18+
19+
/** Constants describing the SDK in use */
20+
export const SDK_INFO = {
21+
NAME: 'opentelemetry',
22+
RUNTIME: 'browser',
23+
LANGUAGE: 'webjs',
24+
VERSION: VERSION,
25+
};

packages/opentelemetry-core/src/platform/browser/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
export * from './constants';
1718
export * from './id';
1819
export * from './performance';
1920
export * from './timer-util';
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/**
2+
* Copyright 2020, OpenTelemetry Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* https://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
17+
import { VERSION } from '../../version';
18+
19+
/** Constants describing the SDK in use */
20+
export const SDK_INFO = {
21+
NAME: 'opentelemetry',
22+
RUNTIME: 'node',
23+
LANGUAGE: 'nodejs',
24+
VERSION: VERSION,
25+
};

packages/opentelemetry-core/src/platform/node/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
export * from './constants';
1718
export * from './id';
1819
export * from './performance';
1920
export * from './timer-util';

packages/opentelemetry-exporter-collector/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@
8585
"dependencies": {
8686
"@grpc/proto-loader": "^0.5.3",
8787
"@opentelemetry/api": "^0.7.0",
88-
"@opentelemetry/base": "^0.7.0",
8988
"@opentelemetry/core": "^0.7.0",
9089
"@opentelemetry/resources": "^0.7.0",
9190
"@opentelemetry/tracing": "^0.7.0",

packages/opentelemetry-exporter-collector/src/CollectorExporter.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { ExportResult } from '@opentelemetry/base';
18-
import { NoopLogger } from '@opentelemetry/core';
17+
import { ExportResult, NoopLogger } from '@opentelemetry/core';
1918
import { ReadableSpan, SpanExporter } from '@opentelemetry/tracing';
2019
import { Attributes, Logger } from '@opentelemetry/api';
2120
import { onInit, onShutdown, sendSpans } from './platform/index';

packages/opentelemetry-exporter-collector/src/transform.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import {
2121
TimedEvent,
2222
TraceState,
2323
} from '@opentelemetry/api';
24-
import { SDK_INFO } from '@opentelemetry/base';
2524
import * as core from '@opentelemetry/core';
2625
import { Resource } from '@opentelemetry/resources';
2726
import { ReadableSpan } from '@opentelemetry/tracing';
@@ -218,8 +217,8 @@ export function toCollectorExportTraceServiceRequest(
218217
const instrumentationLibrarySpans: opentelemetryProto.trace.v1.InstrumentationLibrarySpans = {
219218
spans: spansToBeSent,
220219
instrumentationLibrary: {
221-
name: name || `${SDK_INFO.NAME} - ${SDK_INFO.LANGUAGE}`,
222-
version: SDK_INFO.VERSION,
220+
name: name || `${core.SDK_INFO.NAME} - ${core.SDK_INFO.LANGUAGE}`,
221+
version: core.SDK_INFO.VERSION,
223222
},
224223
};
225224
const resourceSpan: opentelemetryProto.trace.v1.ResourceSpans = {

packages/opentelemetry-exporter-jaeger/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
},
5858
"dependencies": {
5959
"@opentelemetry/api": "^0.7.0",
60-
"@opentelemetry/base": "^0.7.0",
6160
"@opentelemetry/core": "^0.7.0",
6261
"@opentelemetry/tracing": "^0.7.0",
6362
"jaeger-client": "^3.15.0"

packages/opentelemetry-exporter-jaeger/src/jaeger.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
*/
1616

1717
import * as api from '@opentelemetry/api';
18-
import { ExportResult } from '@opentelemetry/base';
19-
import { NoopLogger } from '@opentelemetry/core';
18+
import { ExportResult, NoopLogger } from '@opentelemetry/core';
2019
import { ReadableSpan, SpanExporter } from '@opentelemetry/tracing';
2120
import { Socket } from 'dgram';
2221
import { spanToThrift } from './transform';

packages/opentelemetry-exporter-prometheus/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
},
5656
"dependencies": {
5757
"@opentelemetry/api": "^0.7.0",
58-
"@opentelemetry/base": "^0.7.0",
5958
"@opentelemetry/core": "^0.7.0",
6059
"@opentelemetry/metrics": "^0.7.0",
6160
"prom-client": "^11.5.3"

packages/opentelemetry-exporter-prometheus/src/prometheus.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { ExportResult } from '@opentelemetry/base';
18-
import { NoopLogger, hrTimeToMilliseconds } from '@opentelemetry/core';
17+
import { ExportResult, NoopLogger, hrTimeToMilliseconds } from '@opentelemetry/core';
1918
import {
2019
CounterSumAggregator,
2120
LastValue,

packages/opentelemetry-exporter-zipkin/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
},
5656
"dependencies": {
5757
"@opentelemetry/api": "^0.7.0",
58-
"@opentelemetry/base": "^0.7.0",
5958
"@opentelemetry/core": "^0.7.0",
6059
"@opentelemetry/resources": "^0.7.0",
6160
"@opentelemetry/tracing": "^0.7.0"

packages/opentelemetry-exporter-zipkin/src/zipkin.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,8 @@ import * as types from '@opentelemetry/api';
1818
import * as http from 'http';
1919
import * as https from 'https';
2020
import * as url from 'url';
21-
import { NoopLogger } from '@opentelemetry/core';
21+
import { ExportResult, NoopLogger } from '@opentelemetry/core';
2222
import { SpanExporter, ReadableSpan } from '@opentelemetry/tracing';
23-
import { ExportResult } from '@opentelemetry/base';
2423
import * as zipkinTypes from './types';
2524
import {
2625
toZipkinSpan,

packages/opentelemetry-metrics/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
},
5959
"dependencies": {
6060
"@opentelemetry/api": "^0.7.0",
61-
"@opentelemetry/base": "^0.7.0",
6261
"@opentelemetry/core": "^0.7.0",
6362
"@opentelemetry/resources": "^0.7.0"
6463
}

packages/opentelemetry-metrics/src/export/ConsoleMetricExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { MetricExporter, MetricRecord, Distribution, Histogram } from './types';
18-
import { ExportResult } from '@opentelemetry/base';
18+
import { ExportResult } from '@opentelemetry/core';
1919

2020
/**
2121
* This is implementation of {@link MetricExporter} that prints metrics data to

packages/opentelemetry-metrics/src/export/Controller.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,9 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { unrefTimer } from '@opentelemetry/core';
17+
import { ExportResult, unrefTimer } from '@opentelemetry/core';
1818
import { Meter } from '../Meter';
1919
import { MetricExporter } from './types';
20-
import { ExportResult } from '@opentelemetry/base';
2120

2221
const DEFAULT_EXPORT_INTERVAL = 60_000;
2322

packages/opentelemetry-metrics/src/export/NoopExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { MetricExporter, MetricRecord } from './types';
18-
import { ExportResult } from '@opentelemetry/base';
18+
import { ExportResult } from '@opentelemetry/core';
1919

2020
export class NoopExporter implements MetricExporter {
2121
// By default does nothing

packages/opentelemetry-metrics/src/export/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { ValueType, HrTime, Labels } from '@opentelemetry/api';
18-
import { ExportResult } from '@opentelemetry/base';
18+
import { ExportResult } from '@opentelemetry/core';
1919

2020
/** The kind of metric. */
2121
export enum MetricKind {

packages/opentelemetry-plugin-xml-http-request/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
},
7878
"dependencies": {
7979
"@opentelemetry/api": "^0.7.0",
80-
"@opentelemetry/base": "^0.7.0",
8180
"@opentelemetry/core": "^0.7.0",
8281
"@opentelemetry/web": "^0.7.0",
8382
"shimmer": "^1.2.1"

packages/opentelemetry-resources/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@
6262
},
6363
"dependencies": {
6464
"@opentelemetry/api": "^0.7.0",
65-
"@opentelemetry/base": "^0.7.0",
6665
"gcp-metadata": "^3.5.0"
6766
}
6867
}

packages/opentelemetry-resources/src/Resource.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { SDK_INFO } from '@opentelemetry/base';
17+
import { SDK_INFO } from '@opentelemetry/core';
1818
import { TELEMETRY_SDK_RESOURCE } from './constants';
1919
import { ResourceLabels } from './types';
2020

packages/opentelemetry-tracing/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
},
7575
"dependencies": {
7676
"@opentelemetry/api": "^0.7.0",
77-
"@opentelemetry/base": "^0.7.0",
7877
"@opentelemetry/context-base": "^0.7.0",
7978
"@opentelemetry/core": "^0.7.0",
8079
"@opentelemetry/resources": "^0.7.0"

packages/opentelemetry-tracing/src/export/ConsoleSpanExporter.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616

1717
import { SpanExporter } from './SpanExporter';
1818
import { ReadableSpan } from './ReadableSpan';
19-
import { ExportResult } from '@opentelemetry/base';
20-
import { hrTimeToMicroseconds } from '@opentelemetry/core';
19+
import { ExportResult, hrTimeToMicroseconds } from '@opentelemetry/core';
2120

2221
/**
2322
* This is implementation of {@link SpanExporter} that prints spans to the

packages/opentelemetry-tracing/src/export/InMemorySpanExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import { SpanExporter } from './SpanExporter';
1818
import { ReadableSpan } from './ReadableSpan';
19-
import { ExportResult } from '@opentelemetry/base';
19+
import { ExportResult } from '@opentelemetry/core';
2020

2121
/**
2222
* This class can be used for testing purposes. It stores the exported spans

packages/opentelemetry-tracing/src/export/SpanExporter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { ExportResult } from '@opentelemetry/base';
17+
import { ExportResult } from '@opentelemetry/core';
1818
import { ReadableSpan } from './ReadableSpan';
1919

2020
/**

0 commit comments

Comments
 (0)