Skip to content

Commit 377786b

Browse files
committed
fix(propagator-jaeger):extract 1 digit traceFlag(0) return 1
1 parent f924669 commit 377786b

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

packages/opentelemetry-propagator-jaeger/src/JaegerPropagator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ function deserializeSpanContext(serializedString: string): SpanContext | null {
145145

146146
const traceId = _traceId.padStart(32, '0');
147147
const spanId = _spanId.padStart(16, '0');
148-
const traceFlags = flags.match(/^[0-9a-f]{2}$/i) ? parseInt(flags) & 1 : 1;
148+
const traceFlags = flags.match(/^[0-9a-f]{1,2}$/i) ? parseInt(flags) & 1 : 1;
149149

150150
return { traceId, spanId, isRemote: true, traceFlags };
151151
}

packages/opentelemetry-propagator-jaeger/test/JaegerPropagator.test.ts

+16-1
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ describe('JaegerPropagator', () => {
159159
});
160160
});
161161

162-
it('should extract context of a sampled span from carrier with 1 bit flag', () => {
162+
it('should extract context of a sampled span from carrier with 1 bit flag(1)', () => {
163163
carrier[UBER_TRACE_ID_HEADER] =
164164
'9c41e35aeb6d1272:45fd2a9709dadcf1:a13699e3fb724f40:1';
165165
const extractedSpanContext = trace.getSpanContext(
@@ -174,6 +174,21 @@ describe('JaegerPropagator', () => {
174174
});
175175
});
176176

177+
it("should extract context of a sampled span from carrier with 1 bit flag(0)", () => {
178+
carrier[UBER_TRACE_ID_HEADER] =
179+
"9c41e35aeb6d1272:45fd2a9709dadcf1:a13699e3fb724f40:0";
180+
const extractedSpanContext = trace.getSpanContext(
181+
jaegerPropagator.extract(ROOT_CONTEXT, carrier, defaultTextMapGetter)
182+
);
183+
184+
assert.deepStrictEqual(extractedSpanContext, {
185+
spanId: "45fd2a9709dadcf1",
186+
traceId: "00000000000000009c41e35aeb6d1272",
187+
isRemote: true,
188+
traceFlags: TraceFlags.NONE,
189+
});
190+
});
191+
177192
it('should extract context of a sampled span from UTF-8 encoded carrier', () => {
178193
carrier[UBER_TRACE_ID_HEADER] =
179194
'ac1f3dc3c2c0b06e%3A5ac292c4a11a163e%3Ac086aaa825821068%3A1';

0 commit comments

Comments
 (0)